When we use the same Mailgun domain for other services, the email events
for those services we'll be pushed to the Odoo controller as well. We
want to discard them as they're useless to us.
Aside from that, in the case a wrong db is called to the controller, we
better logging the failed request is going to be more useful than
raising an error.
- Fix tests
- Fix warnings
- Improve code
- Get rid of superfluous stuff
- Remove auto-validation. It couldn't be working as it was and it would
drag performance on contacts creation/write if active.
TT44207
Since 9a47101964
bouncing the emails through the mailgun controller causes a singleton
error when the anonymous user tries to record the bounce message.
TT44585
Mass mailing are tracked from mail.trace as the don't store a message in
the db. In order to gather the message_id and be able to do manual
checks to mailgun, that's the table where we should get the message id.
TT40816
Before this patch, the module was designed after the [deprecated Mailgun webhooks][3]. However Mailgun had the [events API][2] which was quite different. Modern Mailgun has deprecated those webhooks and instead uses new ones that include the same payload as the events API, so you can reuse code.
However, this was incorrectly reusing the code inversely: trying to process the events API through the same code prepared for the deprecated webhooks.
Besides, both `failed` and `rejected` mailgun events were mapped to `error` state, but that was also wrong because [`mail_tracking` doesn't have an `error` state][1].
So the logic of the whole module is changed, adapting it to process the events API payload, both through controllers (prepared for the new webhooks) and manual updates that directly call the events API.
Also, `rejected` is now translated into `reject`, and `failed` is translated into `hard_bounce` or `soft_bounce` depending on the severity, as specified by [mailgun docs][2]. Also, `bounced` and `dropped` mailgun states are removed because they don't exist, and instead `failed` and `rejected` properly get their metadata.
Of course, to know the severity, now the method to obtain that info must change, it' can't be a simple dict anymore.
Added more parameters because for example modern Mailgun uses different keys for signing payload than for accessing the API. As there are so many parameters, configuration is now possible through `res.config.settings`. Go there to autoregister webhooks too.
Since the new webhooks are completely incompatible with the old supposedly-abstract webhooks controllers (that were never really that abstract), support for old webhooks is removed, and it will be removed in the future from `mail_tracking` directly. There is a migration script that attempts to unregister old webhooks and register new ones automatically.
[1]: f73de421e2/mail_tracking/models/mail_tracking_event.py (L31-L42)
[2]: https://documentation.mailgun.com/en/latest/api-events.html#event-types
[3]: https://documentation.mailgun.com/en/latest/api-webhooks-deprecated.html
oca-ci
OCA-git-bot
trisdoan
mymage
Ronald Portier
Stefan Rijnhart
Ivorra78
sonhd91
Nils Hamerlinck
Christoph Abenthung
Hai Lang
Weblate
David
Vincent Hatakeyama
Jesús Alan Ramos Rodríguez
nicolas
Jairo Llopis
Carlos Roca