From fd9c781e468346608d98f5e4337fa80c9546dafc Mon Sep 17 00:00:00 2001 From: nguyenhk Date: Tue, 21 Dec 2021 10:22:55 +0700 Subject: [PATCH] [FIX] web_m2x_options: fix test_ir_config_parameter --- web_m2x_options/models/ir_config_parameter.py | 6 ++---- .../tests/test_ir_config_parameter.py | 16 +++++++--------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/web_m2x_options/models/ir_config_parameter.py b/web_m2x_options/models/ir_config_parameter.py index f6d7b17f7..c24506dd8 100644 --- a/web_m2x_options/models/ir_config_parameter.py +++ b/web_m2x_options/models/ir_config_parameter.py @@ -14,7 +14,5 @@ class IrConfigParameter(models.Model): "web_m2x_options.m2o_dialog", "web_m2x_options.field_limit_entries", ] - return { - res["key"]: res["value"] - for res in self.sudo().search_read([["key", "in", opts]], ["key", "value"]) - } + values = self.sudo().search_read([["key", "in", opts]], ["key", "value"]) + return {res["key"]: res["value"] for res in values} diff --git a/web_m2x_options/tests/test_ir_config_parameter.py b/web_m2x_options/tests/test_ir_config_parameter.py index d4262a252..eae00c7a9 100644 --- a/web_m2x_options/tests/test_ir_config_parameter.py +++ b/web_m2x_options/tests/test_ir_config_parameter.py @@ -16,15 +16,13 @@ class TestIrConfigParameter(common.TransactionCase): def test_web_m2x_options_key(self): web_m2x_options = self.env["ir.config_parameter"].get_web_m2x_options() - options = {opt["key"]: opt["value"] for opt in web_m2x_options} - self.assertIn("web_m2x_options.limit", options) - self.assertNotIn("web_m2x_options.m2o_dialog_test", options) + self.assertIn("web_m2x_options.limit", web_m2x_options) + self.assertNotIn("web_m2x_options.m2o_dialog_test", web_m2x_options) def test_web_m2x_options_value(self): web_m2x_options = self.env["ir.config_parameter"].get_web_m2x_options() - options = {opt["key"]: opt["value"] for opt in web_m2x_options} - self.assertEqual(options["web_m2x_options.limit"], "10") - self.assertTrue(bool(options["web_m2x_options.create_edit"])) - self.assertTrue(bool(options["web_m2x_options.create"])) - self.assertEqual(options["web_m2x_options.search_more"], "False") - self.assertTrue(bool(options["web_m2x_options.m2o_dialog"])) + self.assertEqual(web_m2x_options["web_m2x_options.limit"], "10") + self.assertTrue(bool(web_m2x_options["web_m2x_options.create_edit"])) + self.assertTrue(bool(web_m2x_options["web_m2x_options.create"])) + self.assertEqual(web_m2x_options["web_m2x_options.search_more"], "False") + self.assertTrue(bool(web_m2x_options["web_m2x_options.m2o_dialog"]))