From a3dee355948b7aa4d65aa45433dc49436e4b4980 Mon Sep 17 00:00:00 2001
From: Lois Rilo <lois.rilo@forgeflow.com>
Date: Fri, 4 Sep 2020 09:05:08 +0200
Subject: [PATCH] [13.0][FIX] web_drop_target: improve extensibility

when using the mixin in other widgets you may need to define
a different way to get the record id.
---
 web_drop_target/readme/CONTRIBUTORS.rst          |  1 +
 web_drop_target/static/src/js/web_drop_target.js | 15 ++++++++++++---
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/web_drop_target/readme/CONTRIBUTORS.rst b/web_drop_target/readme/CONTRIBUTORS.rst
index 4230b091a..2eb872e17 100644
--- a/web_drop_target/readme/CONTRIBUTORS.rst
+++ b/web_drop_target/readme/CONTRIBUTORS.rst
@@ -2,3 +2,4 @@
 * Pablo Fuentes <pablo@studio73.es>
 * Akim Juillerat <akim.juillerat@camptocamp.com>
 * Enric Tobella <etobella@creublanca.es>
+* Lois Rilo <lois.rilo@forgeflow.com>
diff --git a/web_drop_target/static/src/js/web_drop_target.js b/web_drop_target/static/src/js/web_drop_target.js
index c4acc06cc..cd96bfda8 100644
--- a/web_drop_target/static/src/js/web_drop_target.js
+++ b/web_drop_target/static/src/js/web_drop_target.js
@@ -52,7 +52,7 @@ odoo.define("web_drop_target", function(require) {
         },
 
         _get_drop_items: function(e) {
-            if (this.renderer.state.res_id) {
+            if (this._get_record_id()) {
                 var self = this,
                     dataTransfer = e.originalEvent.dataTransfer,
                     drop_items = [];
@@ -133,6 +133,12 @@ odoo.define("web_drop_target", function(require) {
             reader.readAsArrayBuffer(file);
         },
 
+        _get_record_id: function() {
+            // Implement when including this mixin. Return the record ID.
+            console.log("'_get_record_id': Not Implemented");
+            return false;
+        },
+
         _add_overlay: function() {
             var self = this;
             if (!this._drop_overlay) {
@@ -140,7 +146,7 @@ odoo.define("web_drop_target", function(require) {
                     view_manager = jQuery(".o_view_manager_content");
                 this._drop_overlay = jQuery(
                     qweb.render("web_drop_target.drop_overlay", {
-                        id: self.renderer.state.res_id,
+                        id: self._get_record_id(),
                     })
                 );
                 var o_content_position = o_content.position();
@@ -150,7 +156,7 @@ odoo.define("web_drop_target", function(require) {
                     width: view_manager.width(),
                     height: view_manager.height(),
                 });
-                if (!this.renderer.state.res_id) {
+                if (!this._get_record_id()) {
                     this._drop_overlay.css("background", "#FF000020");
                 }
                 o_content.append(this._drop_overlay);
@@ -181,6 +187,9 @@ odoo.define("web_drop_target", function(require) {
                     );
                 });
             },
+            _get_record_id: function() {
+                return this.renderer.state.res_id;
+            },
         })
     );