From 5ae07aaaf841f26826dee137936eedbd6c80265a Mon Sep 17 00:00:00 2001 From: Akim Juillerat Date: Thu, 19 Oct 2023 13:29:09 +0200 Subject: [PATCH] web_edit_user_filter: Fix selection of facet When clicking to edit a filter in search view, the _process_filters function will receive the faceID argument as a string, which will be compared to facet.groupId that is an Integer. Therefore we should use == operator when comparing this value to allow type coercion from JS. --- web_edit_user_filter/static/src/js/backend.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web_edit_user_filter/static/src/js/backend.js b/web_edit_user_filter/static/src/js/backend.js index 57672e88d..365ab9113 100644 --- a/web_edit_user_filter/static/src/js/backend.js +++ b/web_edit_user_filter/static/src/js/backend.js @@ -118,7 +118,7 @@ odoo.define("web_edit_user_filter/static/src/js/backend.js", function (require) var selectedFacet = self.model.get("filters").filter(function (facet) { return ( facet.type === facet_type && - facet.groupId === facetId && + facet.groupId == facetId && facet.isActive === true ); }); @@ -129,7 +129,7 @@ odoo.define("web_edit_user_filter/static/src/js/backend.js", function (require) var FavFacets = []; var currentFacet = self.model.get( "filters", - (f) => f.type === "favorite" && f.groupId === facetId + (f) => f.type === "favorite" && f.groupId == facetId ); if (currentFacet[0].groupBys.length) { _.each(currentFacet[0].groupBys, function (description) {