Techsystech
/
web_techsystech
forked from Techsystech/web
3
0
Fork 0
Code Pull Requests Activity

[FIX] web_widget_numeric_step: no input focus on touch screens 

If you're using a tablet and click on the ➕ or ➖ buttons created by this module, the result was that the numeric input related to that button got focused.

On tablets, that means that the on-screen keyboard pops up. This usually triggers a layout recalculation and becomes clunky. Besides, it's useless, because if you wanted to use the keyboard, you'd have clicked on the input by yourself, and not in one of those buttons.

After this change, when using a touch screen, if you click on the +/- buttons, you won't auto-focus on the input. Thus, the keyboard won't show up.

@moduon MT-4472
16.0
Jairo Llopis 2023-12-22 11:29:14 +00:00
parent d66d561d46
commit 48eb4e6727
No known key found for this signature in database
GPG Key ID: E47E3BE44B940490
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
web_widget_numeric_step/static/src/numeric_step.esm.js
View File

@ -4,6 +4,7 @@ import {registry} from "@web/core/registry";
import {standardFieldProps} from "@web/views/fields/standard_field_props";
import {_lt} from "@web/core/l10n/translation";
import {FloatField} from "@web/views/fields/float/float_field";
import {hasTouch} from "@web/core/browser/feature_detection";
export class NumericStep extends FloatField {
setup() {
@ -11,7 +12,9 @@ export class NumericStep extends FloatField {
}
_onStepClick(ev) {
const $el = $(ev.target).parent().parent().find("input");
$el.focus();
if (!hasTouch()) {
$el.focus();
}
const mode = $(ev.target).data("mode");
this._doStep(mode);
}