Techsystech
/
web_techsystech
forked from Techsystech/web
3
0
Fork 0
Code Pull Requests Activity

[FIX] web_decimal_numpad_dot: Fix inconsistent behavior 

When user was replacing some specific sections or being too fast, the module wasn't behaving fine. Also, it was always displaying the original `.` slightly before doing the replacement.
14.0
Jairo Llopis 2019-01-15 10:49:44 +00:00 committed by João Marques
parent d41e2d989d
commit 301cd189cf
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
web_decimal_numpad_dot/static/src/js/numpad_dot.js
View File

@ -9,7 +9,7 @@ odoo.define("web_decimal_numpad_dot.FieldFloat", function (require) {
var NumpadDotReplaceMixin = { var NumpadDotReplaceMixin = {
init: function () { init: function () {
this.events = $.extend({}, this.events, { this.events = $.extend({}, this.events, {
"keyup": "numpad_dot_replace", "keydown": "numpad_dot_replace",
}); });
return this._super.apply(this, arguments); return this._super.apply(this, arguments);
}, },
@ -19,14 +19,13 @@ odoo.define("web_decimal_numpad_dot.FieldFloat", function (require) {
? ":" : translation._t.database.parameters.decimal_point; ? ":" : translation._t.database.parameters.decimal_point;
}, },
_replaceAt: function (cur_val, index, replacement) { _replaceAt: function (cur_val, from, to, replacement) {
return cur_val.substr(0, index) + replacement + return cur_val.substring(0, from) + replacement +
cur_val.substr(index + replacement.length); cur_val.substring(to);
}, },
numpad_dot_replace: function (event) { numpad_dot_replace: function (event) {
// Only act on numpad dot key // Only act on numpad dot key
event.stopPropagation();
if (event.keyCode !== 110) { if (event.keyCode !== 110) {
return; return;
} }
@ -35,7 +34,7 @@ odoo.define("web_decimal_numpad_dot.FieldFloat", function (require) {
to = this.$input.prop("selectionEnd"), to = this.$input.prop("selectionEnd"),
cur_val = this.$input.val(), cur_val = this.$input.val(),
point = this.l10n_decimal_point(); point = this.l10n_decimal_point();
var new_val = this._replaceAt(cur_val, from-1, point); var new_val = this._replaceAt(cur_val, from, to, point);
this.$input.val(new_val); this.$input.val(new_val);
// Put user caret in place // Put user caret in place
to = from + point.length; to = from + point.length;