From 0846c1c8d08d9c0d20b2b0c21f8eeee5e6194f1e Mon Sep 17 00:00:00 2001 From: eng-eslam-a-y Date: Sun, 2 Feb 2020 10:57:39 +0200 Subject: [PATCH 1/2] has to explicit check for type of value !== null has to explicit check for type of value !== null as the typeof null is object https://i.stack.imgur.com/FzI1R.png --- web_edit_user_filter/static/src/js/backend.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web_edit_user_filter/static/src/js/backend.js b/web_edit_user_filter/static/src/js/backend.js index 2c188fd98..49a201a81 100644 --- a/web_edit_user_filter/static/src/js/backend.js +++ b/web_edit_user_filter/static/src/js/backend.js @@ -27,7 +27,7 @@ odoo.define('web_edit_user_filter', function (require) { json_facet.values = facet.get('values'); _.each(json_facet.values, function (value, i) { - if (typeof value.value === 'object' && + if (typeof value.value === 'object' && typeof value.value !== null && 'attrs' in value.value) { json_facet.values[i] = { attrs: value.value.attrs, From d52d15c9d959ce3e73200148cecf3b4517a94f30 Mon Sep 17 00:00:00 2001 From: eng-eslam-a-y Date: Sun, 2 Feb 2020 11:09:52 +0200 Subject: [PATCH 2/2] Update backend.js --- web_edit_user_filter/static/src/js/backend.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web_edit_user_filter/static/src/js/backend.js b/web_edit_user_filter/static/src/js/backend.js index 49a201a81..3f5ab7244 100644 --- a/web_edit_user_filter/static/src/js/backend.js +++ b/web_edit_user_filter/static/src/js/backend.js @@ -27,7 +27,7 @@ odoo.define('web_edit_user_filter', function (require) { json_facet.values = facet.get('values'); _.each(json_facet.values, function (value, i) { - if (typeof value.value === 'object' && typeof value.value !== null && + if (typeof value.value === 'object' && value.value !== null && 'attrs' in value.value) { json_facet.values[i] = { attrs: value.value.attrs,