[IMP] : simplify the code, use filtered function instead of a simple condition

pull/159/head
Adil Houmadi 2015-06-30 12:37:12 +02:00
parent d6a006028e
commit 7deb03adb1
1 changed files with 11 additions and 12 deletions

View File

@ -40,16 +40,15 @@ class web_shortcut(models.Model):
def get_user_shortcuts(self, user_id): def get_user_shortcuts(self, user_id):
shortcuts = self.search([('user_id', '=', user_id)]) shortcuts = self.search([('user_id', '=', user_id)])
res = [] res = []
for shortcut in shortcuts: for shortcut in shortcuts.filtered('menu_id'):
if shortcut.menu_id: _name = shortcut.menu_id.name_get()
_name = shortcut.menu_id.name_get() _name = _name[0][1] if len(_name) else ''
_name = _name[0][1] if len(_name) else '' _id = shortcut.menu_id.id
_id = shortcut.menu_id.id res.append(
res.append( {
{ 'id': shortcut.id,
'id': shortcut.id, 'name': _name,
'name': _name, 'menu_id': (_id, _name)
'menu_id': (_id, _name) }
} )
)
return res return res