From 67be2e06811bba6afa3b108343e1629f71bf38d8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexandre=20D=2E=20D=C3=ADaz?=
 <alexandre.diaz@tecnativa.com>
Date: Tue, 29 Dec 2020 18:38:20 +0100
Subject: [PATCH] [FIX] web_widget_numeric_step: Only modify widget parent

---
 web_widget_numeric_step/__manifest__.py       |  2 +-
 .../static/src/css/numeric_step.scss          |  5 ++
 .../static/src/js/numeric_step.js             | 53 ++++++++++++++++---
 3 files changed, 52 insertions(+), 8 deletions(-)

diff --git a/web_widget_numeric_step/__manifest__.py b/web_widget_numeric_step/__manifest__.py
index 016d35be7..88552ec1f 100644
--- a/web_widget_numeric_step/__manifest__.py
+++ b/web_widget_numeric_step/__manifest__.py
@@ -5,7 +5,7 @@
 {
     'name': "Web Widget Numeric Step",
     'category': "web",
-    'version': "12.0.1.1.4",
+    'version': "12.0.1.2.0",
     'author': "GRAP, Tecnativa, "
               "Odoo Community Association (OCA)",
     'license': 'AGPL-3',
diff --git a/web_widget_numeric_step/static/src/css/numeric_step.scss b/web_widget_numeric_step/static/src/css/numeric_step.scss
index 8518fd700..7ca8bb842 100644
--- a/web_widget_numeric_step/static/src/css/numeric_step.scss
+++ b/web_widget_numeric_step/static/src/css/numeric_step.scss
@@ -1,6 +1,11 @@
 .widget_numeric_step {
     display: inline-flex;
 }
+
 .numeric_step_editing_cell {
     min-width: 120px;
+
+    .input_numeric_step {
+        height: auto;
+    }
 }
diff --git a/web_widget_numeric_step/static/src/js/numeric_step.js b/web_widget_numeric_step/static/src/js/numeric_step.js
index f0eae9759..398de554f 100644
--- a/web_widget_numeric_step/static/src/js/numeric_step.js
+++ b/web_widget_numeric_step/static/src/js/numeric_step.js
@@ -21,6 +21,7 @@ odoo.define('web_widget_numeric_step.field', function (require) {
             'keydown .input_numeric_step': '_onKeyDown',
             'change .input_numeric_step': '_onChange',
             'input .input_numeric_step': '_onInput',
+            'onfocusout .widget_numeric_step': '_onFocusOut',
         }),
         supportedFieldTypes: ['float', 'integer'],
 
@@ -32,6 +33,9 @@ odoo.define('web_widget_numeric_step.field', function (require) {
         DELAY_THROTTLE_CHANGE: 200,
 
 
+        /**
+         * @override
+         */
         init: function () {
             this._super.apply(this, arguments);
 
@@ -124,7 +128,9 @@ odoo.define('web_widget_numeric_step.field', function (require) {
          * @override
          */
         _renderEdit: function () {
-            $("td.o_numeric_step_cell").addClass("numeric_step_editing_cell");
+            _.defer(function () {
+                this.$el.parents("td.o_numeric_step_cell").addClass("numeric_step_editing_cell");
+            }.bind(this));
             this._prepareInput(this.$el.find('input.input_numeric_step'));
         },
 
@@ -134,7 +140,7 @@ odoo.define('web_widget_numeric_step.field', function (require) {
          * @override
          */
         _renderReadonly: function () {
-            $("td.o_numeric_step_cell").removeClass("numeric_step_editing_cell");
+            this.$el.parents("td.numeric_step_editing_cell").removeClass("numeric_step_editing_cell");
             this._super.apply(this, arguments);
         },
 
@@ -166,7 +172,21 @@ odoo.define('web_widget_numeric_step.field', function (require) {
             }
         },
 
+        /**
+         * @private
+         */
+        _clearStepInterval: function () {
+            clearTimeout(this._auto_step_interval);
+            this._auto_step_interval = false;
+            this._click_delay = this.DEF_CLICK_DELAY;
+        },
+
         // Handle Events
+
+        /**
+         * @private
+         * @param {MouseClickEvent} ev
+         */
         _onStepClick: function (ev) {
             if (!this._autoStep) {
                 var mode = ev.target.dataset.mode;
@@ -175,19 +195,38 @@ odoo.define('web_widget_numeric_step.field', function (require) {
             this._autoStep = false;
         },
 
+        /**
+         * @private
+         * @param {MouseClickEvent} ev
+         */
         _onStepMouseDown: function (ev) {
-            if (!this._auto_step_interval) {
+            if (ev.button === 0 && !this._auto_step_interval) {
                 this._auto_step_interval = setTimeout(
                     $.proxy(this, "_whileMouseDown", ev), this._click_delay);
             }
         },
 
-        _onMouseUp: function () {
-            clearTimeout(this._auto_step_interval);
-            this._auto_step_interval = false;
-            this._click_delay = this.DEF_CLICK_DELAY;
+        /**
+         * @private
+         * @param {FocusoutEvent} ev
+         */
+        _onFocusOut: function (evt) {
+            if (this._auto_step_interval) {
+                this._clearStepInterval();
+            }
         },
 
+        /**
+         * @private
+         */
+        _onMouseUp: function () {
+            this._clearStepInterval();
+        },
+
+        /**
+         * @private
+         * @param {MouseClickEvent} ev
+         */
         _whileMouseDown: function (ev) {
             this._autoStep = true;
             var mode = ev.target.dataset.mode;