Commit Graph

14 Commits (f61c21bcc04784544d4733d79953d9292e67db6c)

Author SHA1 Message Date
Jairo Llopis 8681bc0fc4 [IMP] mail_tracking_mailgun: refactor to support modern webhooks
Before this patch, the module was designed after the [deprecated Mailgun webhooks][3]. However Mailgun had the [events API][2] which was quite different. Modern Mailgun has deprecated those webhooks and instead uses new ones that include the same payload as the events API, so you can reuse code.

However, this was incorrectly reusing the code inversely: trying to process the events API through the same code prepared for the deprecated webhooks.

Besides, both `failed` and `rejected` mailgun events were mapped to `error` state, but that was also wrong because [`mail_tracking` doesn't have an `error` state][1].

So the logic of the whole module is changed, adapting it to process the events API payload, both through controllers (prepared for the new webhooks) and manual updates that directly call the events API.

Also, `rejected` is now translated into `reject`, and `failed` is translated into `hard_bounce` or `soft_bounce` depending on the severity, as specified by [mailgun docs][2]. Also, `bounced` and `dropped` mailgun states are removed because they don't exist, and instead `failed` and `rejected` properly get their metadata.

Of course, to know the severity, now the method to obtain that info must change, it' can't be a simple dict anymore.

Added more parameters because for example modern Mailgun uses different keys for signing payload than for accessing the API. As there are so many parameters, configuration is now possible through `res.config.settings`. Go there to autoregister webhooks too.

Since the new webhooks are completely incompatible with the old supposedly-abstract webhooks controllers (that were never really that abstract), support for old webhooks is removed, and it will be removed in the future from `mail_tracking` directly. There is a migration script that attempts to unregister old webhooks and register new ones automatically.

[1]: f73de421e2/mail_tracking/models/mail_tracking_event.py (L31-L42)
[2]: https://documentation.mailgun.com/en/latest/api-events.html#event-types
[3]: https://documentation.mailgun.com/en/latest/api-webhooks-deprecated.html
2021-11-25 10:41:08 +01:00
hveficent f1db32e70c [MIG] mail_tracking_mailgun: Migration to 13.0 2020-04-02 11:18:36 +02:00
hveficent 4293c52365 [IMP] mail_tracking_mailgun: black, isort 2020-04-02 11:15:51 +02:00
David 07de18ae94 [IMP] mail_tracking_mailgun: link to bounce event 2020-04-02 11:13:04 +02:00
ernesto c813615ed4 [MIG] mail_tracking_mailgun: Migration to 12.0 2020-04-02 11:13:04 +02:00
David dea8c21720 [FIX] mail_tracking_mailgun: Validation API url
Besides Mailgun API url changes if the domain zone is in UE, it
remains the same for Validation API.
2020-04-02 11:13:04 +02:00
Sergio Teruel Albert 5638ce499b [11.0][FIX] mail_tracking_mailgun: Read config parameters with sudo 2020-04-02 11:13:04 +02:00
David Vidal 1f684ad7ad [FIX] mail_tracking_mailgun: json.load() won't swallow bytes (#269)
- json.load() in python under 3.6 doesn't support binary input.
- https://docs.python.org/3/whatsnew/3.6.html#json
- This way, we let requests to decode the response itself.
2020-04-02 11:13:04 +02:00
David 96b203adc4 [MIG] mail_tracking_mailgun: Migration to 11.0 2020-04-02 11:13:04 +02:00
David f12d809866 [IMP] mail_tracking_mailgun: validation auto check
- Configurable partner email auto check.
2020-04-02 11:13:04 +02:00
Pedro M. Baeza fc9ccf3a22 [FIX] mail_tracking_mailgun: Message error on bounce 2020-04-02 11:13:04 +02:00
Jairo Llopis ea7d9836da [FIX] mail_tracking_mailgun: Avoid errors without event
When this method is called without an event (a.k.a. `event=None`), this method produces the following error:

```
Traceback (most recent call last):
  File "/opt/odoo/auto/addons/mail/models/mail_mail.py", line 278, in send
    res = IrMailServer.send_email(msg, mail_server_id=mail.mail_server_id.id)
  File "/opt/odoo/auto/addons/mail_tracking/models/ir_mail_server.py", line 88, in send_email
    tracking_email.smtp_error(self, smtp_server_used, e)
  File "/opt/odoo/auto/addons/mail_tracking/models/mail_tracking_email.py", line 213, in smtp_error
    self.sudo()._partners_email_bounced_set('error')
  File "/opt/odoo/auto/addons/mail_tracking/models/mail_tracking_email.py", line 203, in
_partners_email_bounced_set
    ]).email_bounced_set(self, reason, event=event)
  File "/opt/odoo/auto/addons/mail_tracking_mailgun/models/res_partner.py", line 22, in
email_bounced_set
    self._email_bounced_set(reason, event)
  File "/opt/odoo/auto/addons/mail_tracking_mailgun/models/res_partner.py", line 33, in
_email_bounced_set
    event['Message-Id'] or '') TypeError: 'NoneType' object has no attribute '__getitem__'
```

So, we now assume we do not always have an event.
2020-04-02 11:13:04 +02:00
David 811aedb7f6 [10.0][FIX] mail_tracking_mailgun: Avoid key dict errors 2020-04-02 11:13:04 +02:00
David 5f80d83478 [10.0][IMP] mail_tracking_mailgun: add partner mail checks 2020-04-02 11:13:04 +02:00