Mass mailing are tracked from mail.trace as the don't store a message in
the db. In order to gather the message_id and be able to do manual
checks to mailgun, that's the table where we should get the message id.
TT40816
Under certain circumstances setting the bounce to hard faild partner
leads to a triggering of the property_pricelist recomputation. We need to set
company, user and uid for the query build to work correctly:
https://github.com/odoo/odoo/blob/13.0/odoo/addons/base/models/ir_property.py#L240
The result is an inderect error that impedes the correct bounce flagging and
the event record creation:
> ERROR prod odoo.sql_db: bad query:
>
> SELECT substr(p.res_id, 13)::integer, r.id
> FROM ir_property p
> LEFT JOIN product_pricelist r ON substr(p.value_reference, 19)::integer=r.id
> WHERE p.fields_id=2440
> AND (p.company_id=false OR p.company_id IS NULL)
> AND (p.res_id IN ('res.partner,45621') OR p.res_id IS NULL)
> ORDER BY p.company_id NULLS FIRST
>
> ERROR: operator does not exist: integer = boolean
> LINE 6: AND (p.company_id=false OR p.company_id ...
As far as we could research, this doesn't happen in >v14. So this nasty glitch
only needs a fix for this version.
TT40816
Before this patch, the module was designed after the [deprecated Mailgun webhooks][3]. However Mailgun had the [events API][2] which was quite different. Modern Mailgun has deprecated those webhooks and instead uses new ones that include the same payload as the events API, so you can reuse code.
However, this was incorrectly reusing the code inversely: trying to process the events API through the same code prepared for the deprecated webhooks.
Besides, both `failed` and `rejected` mailgun events were mapped to `error` state, but that was also wrong because [`mail_tracking` doesn't have an `error` state][1].
So the logic of the whole module is changed, adapting it to process the events API payload, both through controllers (prepared for the new webhooks) and manual updates that directly call the events API.
Also, `rejected` is now translated into `reject`, and `failed` is translated into `hard_bounce` or `soft_bounce` depending on the severity, as specified by [mailgun docs][2]. Also, `bounced` and `dropped` mailgun states are removed because they don't exist, and instead `failed` and `rejected` properly get their metadata.
Of course, to know the severity, now the method to obtain that info must change, it' can't be a simple dict anymore.
Added more parameters because for example modern Mailgun uses different keys for signing payload than for accessing the API. As there are so many parameters, configuration is now possible through `res.config.settings`. Go there to autoregister webhooks too.
Since the new webhooks are completely incompatible with the old supposedly-abstract webhooks controllers (that were never really that abstract), support for old webhooks is removed, and it will be removed in the future from `mail_tracking` directly. There is a migration script that attempts to unregister old webhooks and register new ones automatically.
[1]: f73de421e2/mail_tracking/models/mail_tracking_event.py (L31-L42)
[2]: https://documentation.mailgun.com/en/latest/api-events.html#event-types
[3]: https://documentation.mailgun.com/en/latest/api-webhooks-deprecated.html
This change let odoo process a state sent from mailgun legacy webhooks
that seems to apply when the message is not sent because the related
email has been mark us as spam or have bounced before. For solve this
add two new states to _mailgun_event_type_mapping_mailgun_event_type_mapping
method:
* failed: Mailgun could not deliver the email to the recipient email server
* rejected: Mailgun rejected the request to send/forward the email
source in https://documentation.mailgun.com/en/latest/quickstart-events.html#events.
OCA-git-bot
Weblate
oca-ci
David
Pedro M. Baeza
OCA Transbot
oca-travis
Jairo Llopis
Alexandre D. Díaz
Holger Brunn
hveficent
Matjaz Mozetic
Katherine Zaoral
Pedro Castro Silva
ernesto
c2cdidier
Sergio Teruel Albert