Commit Graph

13 Commits (df25ca0dda7bee0f42101ba3b02d62be2e6812d5)

Author SHA1 Message Date
Jairo Llopis 0f37487265
[IMP] mail_tracking_mailgun: refactor to support modern webhooks
Before this patch, the module was designed after the [deprecated Mailgun webhooks][3]. However Mailgun had the [events API][2] which was quite different. Modern Mailgun has deprecated those webhooks and instead uses new ones that include the same payload as the events API, so you can reuse code.

However, this was incorrectly reusing the code inversely: trying to process the events API through the same code prepared for the deprecated webhooks.

Besides, both `failed` and `rejected` mailgun events were mapped to `error` state, but that was also wrong because [`mail_tracking` doesn't have an `error` state][1].

So the logic of the whole module is changed, adapting it to process the events API payload, both through controllers (prepared for the new webhooks) and manual updates that directly call the events API.

Also, `rejected` is now translated into `reject`, and `failed` is translated into `hard_bounce` or `soft_bounce` depending on the severity, as specified by [mailgun docs][2]. Also, `bounced` and `dropped` mailgun states are removed because they don't exist, and instead `failed` and `rejected` properly get their metadata.

Of course, to know the severity, now the method to obtain that info must change, it' can't be a simple dict anymore.

Added more parameters because for example modern Mailgun uses different keys for signing payload than for accessing the API. As there are so many parameters, configuration is now possible through `res.config.settings`. Go there to autoregister webhooks too.

Since the new webhooks are completely incompatible with the old supposedly-abstract webhooks controllers (that were never really that abstract), support for old webhooks is removed, and it will be removed in the future from `mail_tracking` directly. There is a migration script that attempts to unregister old webhooks and register new ones automatically.

[1]: f73de421e2/mail_tracking/models/mail_tracking_event.py (L31-L42)
[2]: https://documentation.mailgun.com/en/latest/api-events.html#event-types
[3]: https://documentation.mailgun.com/en/latest/api-webhooks-deprecated.html
2021-10-28 11:33:59 +01:00
ernesto 8783e4f6f1 [MIG] mail_tracking_mailgun: Migration to 12.0 2019-03-07 09:24:55 +00:00
David df32385dcb [FIX] mail_tracking_mailgun: alternative domain
- In case the sending domain is different from the one configured in the
mail.domain.catchall setting.
2019-03-07 09:24:55 +00:00
David Vidal 430cb5f4f7 [FIX] mail_tracking_mailgun: json.load() won't swallow bytes (#269)
- json.load() in python under 3.6 doesn't support binary input.
- https://docs.python.org/3/whatsnew/3.6.html#json
- This way, we let requests to decode the response itself.
2019-03-07 09:24:55 +00:00
David 6e1db677c3 [MIG] mail_tracking_mailgun: Migration to 11.0 2019-03-07 09:24:55 +00:00
David 213213c5a0 [IMP] mail_tracking_mailgun: validation auto check
- Configurable partner email auto check.
2019-03-07 09:24:55 +00:00
David 5da0596f9f [FIX] mail_tracking_mailgun: manual sync gets events from other recipients 2019-03-07 09:24:55 +00:00
Pedro M. Baeza d76123c4cd [FIX] mail_tracking_mailgun: Missing error in test 2019-03-07 09:24:55 +00:00
Pedro M. Baeza 78fdbbc4f7 [FIX] mail_tracking_mailgun: Message error on bounce 2019-03-07 09:24:55 +00:00
David 476b8d43e1 [10.0][IMP] mail_tracking_mailgun: add partner mail checks 2019-03-07 09:24:55 +00:00
David Vidal 3bd779dc98 [IMP] mute logger on tests error responses so Travis doesn't fail 2019-03-07 09:24:55 +00:00
Damien Bouvy 316f061f49 [MIG] mail_tracking_mailgun: Migrated to 10.0 2019-03-07 09:24:55 +00:00
Antonio Espinosa cc2f9dcdcd [ADD] mail_tracking_mailgun 2019-03-07 09:24:55 +00:00