If premailer receives an empty value, such as an empty string,
on parsing, it returns None and fails when trying to call
'etree.fromstring()' on this None result.
We should avoid to call premailer on an empty string, as the result
will anyway not change.
We may have an empty template for instance when a template could not
compile due to a mistake.
This addon extends the unsubscription process for allowing to unsubscribe
only for an event.
Standard process includes the mail in the general blacklist instead, which
can be very unconvenient.
This includes also the needed changes in the base module `mass_mailing_custom_unsubscribe`.
- Imported last updates from v8.
- Adapted to v9.
- Added a saner default to `mass_mailing.salt` configuration parameter by
reusing `database.secret` if available, hoping that some day
https://github.com/odoo/odoo/pull/12040 gets merged.
- Updated README.
- Increase security, drop backwards compatibility.
Security got improved upstream, which would again break compatibility among current addon and future master upstream.
I choose to break it now and keep it secured future-wise, so I drop the backwards compatibility features.
- Includes tour tests.
- Removes outdated tests.
- Extends the mailing list management form when unsubscriber is a contact.
- Adds a reason form even if he is not.
- Avoids all methods that were not model-agnostic.
[FIX][mass_mailing_custom_unsubscribe] Reasons noupdate
After this fix, when you update the addon, you will not lose your customized reasons.
[FIX] Compatibilize with mass_mailing_partner
Current test code was based on the assumption that the `@api.model` decorator on `create()` ensured an empty recordset when running the method, but that's not true. This was causing an incompatibility betwee these tests and the `mass_mailing_partner` addon, which works assuming 0-1 recordsets.
Now records are created from an empty recordset, and thus tests work everywhere.
Update instructions
If the user does not add the unsubscribe snippet, nothing will happen, so it's added to README to avoid confusion when testing/using the addon.
[FIX] Use the right operator to preserve recordsets order
Using `|=` sorts records at will each time (treating them as Python's `set`).
Using `+=` always appends a record to the end of the set.
Since we are using the record position in the set, this caused the test to work sometimes and fail other times. Now it works always.
OCA-git-bot
Guewen Baconnier
oca-travis
Carlos Roca
Denis Leemann
Radovan Skolnik
OCA Transbot
David Beal
Matjaz Mozetic
Rodrigo Macedo
ernesto
Damien Bouvy
Sergio Teruel Albert
Adrien Peiffer (ACSONE)
Pedro M. Baeza
c2cdidier
Stéphane Bidoul (ACSONE)
David
Jairo Llopis
Jairo Llopis
Pedro M. Baeza