Techsystech
/
social
mirror of https://github.com/OCA/social.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[FIX] mail_tracking: failed message compute performance 

The failed messages computation relies on a dotted notation search on
the message mail_tracking_ids. This causes a really bad performance in
almost any model with a mail.thread. It's a good use case for auto_join.

TT41397
pull/1052/head
David 2023-01-30 12:10:58 +01:00
parent 1020daacb6
commit edef8c80cb
2 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
mail_tracking/models/mail_message.py
View File

@ -20,6 +20,7 @@ class MailMessage(models.Model):
mail_tracking_ids = fields.One2many( mail_tracking_ids = fields.One2many(
comodel_name="mail.tracking.email", comodel_name="mail.tracking.email",
inverse_name="mail_message_id", inverse_name="mail_message_id",
auto_join=True,
string="Mail Trackings", string="Mail Trackings",
) )
mail_tracking_needs_action = fields.Boolean( mail_tracking_needs_action = fields.Boolean(

14
mail_tracking/models/mail_tracking_email.py
View File

@ -158,10 +158,16 @@ class MailTrackingEmail(models.Model):
if not msg_linked: if not msg_linked:
return [] return []
ids, msg_ids, mail_ids, partner_ids = zip(*msg_linked) ids, msg_ids, mail_ids, partner_ids = zip(*msg_linked)
# Filter messages with their ACL rules # Filter messages with their ACL rules avoiding False values fetched in the set
msg_ids = self.env["mail.message"]._search([("id", "in", msg_ids)]) msg_ids = self.env["mail.message"]._search(
mail_ids = self.env["mail.mail"]._search([("id", "in", mail_ids)]) [("id", "in", [x for x in msg_ids if x])]
partner_ids = self.env["res.partner"]._search([("id", "in", partner_ids)]) )
mail_ids = self.env["mail.mail"]._search(
[("id", "in", [x for x in mail_ids if x])]
)
partner_ids = self.env["res.partner"]._search(
[("id", "in", [x for x in partner_ids if x])]
)
return [ return [
x[0] x[0]
for x in msg_linked for x in msg_linked