diff --git a/mail_debrand/models/mail_render_mixinANDmail_mail.py b/mail_debrand/models/mail_render_mixinANDmail_mail.py index 61f67e7d3..d62f2a814 100644 --- a/mail_debrand/models/mail_render_mixinANDmail_mail.py +++ b/mail_debrand/models/mail_render_mixinANDmail_mail.py @@ -15,17 +15,20 @@ class MailRenderMixin(models.AbstractModel): def remove_href_odoo(self, value, remove_parent=True, remove_before=False): if len(value) < 20: return value + # value can be bytes type; ensure we get a proper string + if type(value) is bytes: + value = value.decode() has_odoo_link = re.search(r" bytes_text = etree.tostring( previous, pretty_print=True, method="html" @@ -33,7 +36,7 @@ class MailRenderMixin(models.AbstractModel): only_what_is_in_tags = bytes_text[: bytes_text.rfind(b">") + 1] data_formatted = html.fromstring(only_what_is_in_tags) parent.replace(previous, data_formatted) - if len(parent.getparent()) and remove_parent: + if remove_parent and len(parent.getparent()): # anchor