From f821b3f46dbbe03f79bd5cf9bc5c679e909c3082 Mon Sep 17 00:00:00 2001 From: Thierry Ducrest Date: Fri, 27 Apr 2018 00:07:57 +0200 Subject: [PATCH 01/14] [10.0] Improving the mail tracking value (#170) Improve the tracking of changed values on database fields ("mail.tracking.value" functionality) by adding many2many and one2many support. As well as a more user friendly view to consult changes recorded. --- mail_improved_tracking_value/README.rst | 77 +++++++++ mail_improved_tracking_value/__init__.py | 5 + mail_improved_tracking_value/__manifest__.py | 23 +++ .../models/__init__.py | 5 + .../models/mail_tracking_value.py | 78 +++++++++ .../tests/__init__.py | 1 + .../tests/test_improved_tracking_value.py | 154 ++++++++++++++++++ .../views/mail_tracking_value.xml | 74 +++++++++ 8 files changed, 417 insertions(+) create mode 100644 mail_improved_tracking_value/README.rst create mode 100644 mail_improved_tracking_value/__init__.py create mode 100644 mail_improved_tracking_value/__manifest__.py create mode 100644 mail_improved_tracking_value/models/__init__.py create mode 100644 mail_improved_tracking_value/models/mail_tracking_value.py create mode 100644 mail_improved_tracking_value/tests/__init__.py create mode 100644 mail_improved_tracking_value/tests/test_improved_tracking_value.py create mode 100644 mail_improved_tracking_value/views/mail_tracking_value.xml diff --git a/mail_improved_tracking_value/README.rst b/mail_improved_tracking_value/README.rst new file mode 100644 index 000000000..1d07764bb --- /dev/null +++ b/mail_improved_tracking_value/README.rst @@ -0,0 +1,77 @@ +.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 + +============================== +Tracking value change improved +============================== + +This module extends the mail_tracking_value functionality that records +value changes on predefined fields. +It adds support for many2many and one2many fields, which are not handled +well by default. +It also implements a new view (little bit more user friendly than the +existing one) to watch for changes + +Installation +============ + +To install this module, you need to: + +#. Just install the module + +Configuration +============= + +To configure this module, you need to: + +# No configuration is necessary + +Usage +===== + +To access the new view displaying value changes : + + Settings -> Technical -> Improved tracking values + + +Known issues / Roadmap +====================== + + * Improve rendering of values depending of type using qweb widgets + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues +`_. In case of trouble, please +check there if your issue has already been reported. If you spotted it first, +help us smash it by providing detailed and welcomed feedback. + +Credits +======= + +Images +------ + +* Odoo Community Association: `Icon `_. + +Contributors +------------ + +* Thierry Ducrest + +Maintainer +---------- + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +This module is maintained by the OCA. + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +To contribute to this module, please visit https://odoo-community.org. diff --git a/mail_improved_tracking_value/__init__.py b/mail_improved_tracking_value/__init__.py new file mode 100644 index 000000000..955b6c584 --- /dev/null +++ b/mail_improved_tracking_value/__init__.py @@ -0,0 +1,5 @@ +# -*- coding: utf-8 -*- +# Copyright 2017 Camptocamp SA +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). + +from . import models diff --git a/mail_improved_tracking_value/__manifest__.py b/mail_improved_tracking_value/__manifest__.py new file mode 100644 index 000000000..879db4825 --- /dev/null +++ b/mail_improved_tracking_value/__manifest__.py @@ -0,0 +1,23 @@ +# -*- coding: utf-8 -*- +# Copyright 2017 Camptocamp SA +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). + +{ + 'name': 'Improved tracking value change', + 'version': '10.0.1.0.0', + 'summary': 'Improves tracking changed values for certain type of fields.' + 'Adds a user-friendly view to consult them.', + 'author': 'Camptocamp, Odoo Community Association (OCA)', + 'license': 'AGPL-3', + 'category': 'Tools', + 'website': 'http://www.camptocamp.com', + 'depends': [ + 'base', + 'mail' + ], + 'data': [ + 'views/mail_tracking_value.xml' + ], + 'installable': True, + 'auto_install': False, +} diff --git a/mail_improved_tracking_value/models/__init__.py b/mail_improved_tracking_value/models/__init__.py new file mode 100644 index 000000000..fa64a900e --- /dev/null +++ b/mail_improved_tracking_value/models/__init__.py @@ -0,0 +1,5 @@ +# -*- coding: utf-8 -*- +# Copyright 2017 Camptocamp SA +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). + +from . import mail_tracking_value diff --git a/mail_improved_tracking_value/models/mail_tracking_value.py b/mail_improved_tracking_value/models/mail_tracking_value.py new file mode 100644 index 000000000..3cdced2d7 --- /dev/null +++ b/mail_improved_tracking_value/models/mail_tracking_value.py @@ -0,0 +1,78 @@ +# -*- coding: utf-8 -*- +# Copyright 2017 Camptocamp SA +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). + +import json + +from odoo import api, fields, models + + +class MailTrackingValue(models.Model): + + _inherit = "mail.tracking.value" + + new_value_formatted = fields.Char(compute='_compute_formatted_value', + string='New value') + old_value_formatted = fields.Char(compute='_compute_formatted_value', + string='Old value') + record_name = fields.Char(related='mail_message_id.record_name') + model = fields.Char(related='mail_message_id.model', store='True', + string='Model') + + @api.depends('new_value_char', 'new_value_integer', 'new_value_float', + 'new_value_text', 'new_value_datetime', 'new_value_monetary', + 'old_value_char', 'old_value_integer', 'old_value_float', + 'old_value_text', 'old_value_datetime', 'old_value_monetary') + def _compute_formatted_value(self): + """ Sets the value formatted field used in the view """ + # Could be improved, by styling in the view depending on type of field + for record in self: + if record.field_type in ('many2many', 'one2many', 'char'): + record.new_value_formatted = record.new_value_char + record.old_value_formatted = record.old_value_char + elif record.field_type == 'integer': + record.new_value_formatted = str(record.new_value_integer) + record.old_value_formatted = str(record.old_value_integer) + elif record.field_type == 'float': + record.new_value_formatted = str(record.new_value_float) + record.old_value_formatted = str(record.old_value_float) + elif record.field_type == 'monetary': + record.new_value_formatted = str(record.new_value_monetary) + record.old_value_formatted = str(record.old_value_monetary) + elif record.field_type == 'datetime': + record.new_value_formatted = str(record.new_value_datetime) + record.old_value_formatted = str(record.old_value_datetime) + elif record.field_type == 'text': + record.new_value_formatted = record.new_value_text + record.old_value_formatted = record.old_value_text + + @api.model + def create_tracking_values(self, old_value, new_value, col_name, col_info): + """ Add tacking capabilities for many2many and one2many fields """ + if col_info['type'] in ('many2many', 'one2many'): + + def get_values(source, prefix): + if source: + names = ', '.join(source.mapped('display_name')) + json_ids = json.dumps(source.ids) + else: + names = '' + json_ids = json.dumps([]) + return { + '{}_value_char'.format(prefix): names, + '{}_value_text'.format(prefix): json_ids, + } + + values = { + 'field': col_name, + 'field_desc': col_info['string'], + 'field_type': col_info['type'], + } + values.update(get_values(old_value, 'old')) + values.update(get_values(new_value, 'new')) + return values + else: + return super(MailTrackingValue, self).create_tracking_values( + old_value, new_value, + col_name, col_info + ) diff --git a/mail_improved_tracking_value/tests/__init__.py b/mail_improved_tracking_value/tests/__init__.py new file mode 100644 index 000000000..89f3720d6 --- /dev/null +++ b/mail_improved_tracking_value/tests/__init__.py @@ -0,0 +1 @@ +from . import test_improved_tracking_value diff --git a/mail_improved_tracking_value/tests/test_improved_tracking_value.py b/mail_improved_tracking_value/tests/test_improved_tracking_value.py new file mode 100644 index 000000000..45c07b2d5 --- /dev/null +++ b/mail_improved_tracking_value/tests/test_improved_tracking_value.py @@ -0,0 +1,154 @@ +# -*- coding: utf-8 -*- +# Copyright 2018 Camptocamp SA +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html) + +import json +from odoo.tests.common import TransactionCase + + +class TestImproveTrackingValue(TransactionCase): + + def setUp(self): + super(TestImproveTrackingValue, self).setUp() + self.model = self.env['mail.tracking.value'] + self.msg = self.env['mail.message'].create({ + 'message_type': 'email' + }) + self.mr = self.env.ref('base.res_partner_title_mister') + self.dr = self.env.ref('base.res_partner_title_doctor') + self.mm = self.env.ref('base.res_partner_title_madam') + self.pf = self.env.ref('base.res_partner_title_prof') + + def test_change_one2many(self): + """Test tracking one2many changes""" + tracking = self.model.create_tracking_values( + self.mr, self.dr, 'testing_col', + {'string': 'TestingField', 'type': 'one2many'}) + self.assertEqual(tracking['old_value_char'], self.mr.display_name) + self.assertEqual(tracking['new_value_char'], self.dr.display_name) + self.assertEqual(tracking['old_value_text'], json.dumps([self.mr.id])) + self.assertEqual(tracking['new_value_text'], json.dumps([self.dr.id])) + + def test_change_one2many_empty(self): + """Test tracking one2many changes emtpy""" + tracking = self.model.create_tracking_values( + self.mr, None, 'testing_col', + {'string': 'TestingField', 'type': 'one2many'}) + self.assertEqual(tracking['old_value_char'], self.mr.display_name) + self.assertEqual(tracking['new_value_char'], '') + self.assertEqual(tracking['old_value_text'], json.dumps([self.mr.id])) + self.assertEqual(tracking['new_value_text'], json.dumps([])) + + def test_change_many2many(self): + """Test tracking many2many changes""" + oldvalue = self.env['res.partner.title'].browse([self.mr.id, + self.dr.id]) + newvalue = self.env['res.partner.title'].browse([self.mm.id, + self.pf.id]) + tracking = self.model.create_tracking_values( + oldvalue, newvalue, 'testing_col', + {'string': 'TestingField', 'type': 'many2many'}) + self.assertEqual(tracking['old_value_char'], + self.mr.display_name + ', ' + self.dr.display_name) + self.assertEqual(tracking['new_value_char'], + self.mm.display_name + ', ' + self.pf.display_name) + self.assertEqual(tracking['old_value_text'], + json.dumps(oldvalue.ids)) + self.assertEqual(tracking['new_value_text'], + json.dumps(newvalue.ids)) + + def test_char_tracking_value(self): + r = self.model.create({ + 'mail_message_id': self.msg.id, + 'field_type': 'char', + 'old_value_char': 'weakness', + 'new_value_char': 'strength', + 'field': 'test', + 'field_desc': 'desc', + }) + self.assertEqual(r.old_value_formatted, 'weakness') + self.assertEqual(r.new_value_formatted, 'strength') + + def test_many2many_tracking_value(self): + r = self.model.create({ + 'mail_message_id': self.msg.id, + 'field_type': 'many2many', + 'old_value_char': '123', + 'new_value_char': '456', + 'field': 'test', + 'field_desc': 'desc', + }) + self.assertEqual(r.old_value_formatted, '123') + self.assertEqual(r.new_value_formatted, '456') + + def test_one2many_tracking_value(self): + r = self.model.create({ + 'mail_message_id': self.msg.id, + 'field_type': 'one2many', + 'old_value_char': '123', + 'new_value_char': '456', + 'field': 'test', + 'field_desc': 'desc', + }) + self.assertEqual(r.old_value_formatted, '123') + self.assertEqual(r.new_value_formatted, '456') + + def test_integer_tracking_value(self): + r = self.model.create({ + 'mail_message_id': self.msg.id, + 'field_type': 'integer', + 'old_value_integer': 1, + 'new_value_integer': 3, + 'field': 'test', + 'field_desc': 'desc', + }) + self.assertEqual(r.old_value_formatted, str(1)) + self.assertEqual(r.new_value_formatted, str(3)) + + def test_float_tracking_value(self): + r = self.model.create({ + 'mail_message_id': self.msg.id, + 'field_type': 'float', + 'old_value_float': 1.1, + 'new_value_float': 3.14159, + 'field': 'test', + 'field_desc': 'desc', + }) + self.assertEqual(r.old_value_formatted, str(1.1)) + self.assertEqual(r.new_value_formatted, str(3.14159)) + + def test_monetary_tracking_value(self): + r = self.model.create({ + 'mail_message_id': self.msg.id, + 'field_type': 'monetary', + 'old_value_monetary': 3.45, + 'new_value_monetary': 5.45, + 'field': 'test', + 'field_desc': 'desc', + }) + self.assertEqual(r.old_value_formatted, str(3.45)) + self.assertEqual(r.new_value_formatted, str(5.45)) + + def test_datetime_tracking_value(self): + r = self.model.create({ + 'mail_message_id': self.msg.id, + 'field_type': 'datetime', + 'old_value_datetime': '2018-01-01', + 'new_value_datetime': '2018-01-04', + 'field': 'test', + 'field_desc': 'desc', + }) + self.assertEqual(r.old_value_formatted, '2018-01-01 00:00:00') + self.assertEqual(r.new_value_formatted, '2018-01-04 00:00:00') + + def test_text_tracking_value(self): + r = self.model.create({ + 'mail_message_id': self.msg.id, + 'field_type': 'text', + 'old_value_text': 'previous', + 'new_value_text': 'next', + 'field': 'test', + 'field_desc': 'desc', + }) + self.assertEqual(r.old_value_formatted, 'previous') + self.assertEqual(r.new_value_formatted, 'next') diff --git a/mail_improved_tracking_value/views/mail_tracking_value.xml b/mail_improved_tracking_value/views/mail_tracking_value.xml new file mode 100644 index 000000000..43e74f35e --- /dev/null +++ b/mail_improved_tracking_value/views/mail_tracking_value.xml @@ -0,0 +1,74 @@ + + + + + Tracking change list" + mail.tracking.value + + + + + + + + + + + + + + Tracking change form + mail.tracking.value + + +
+ + + + + + + + + + + + +
+
+
+ + + Tracking change list filter + mail.tracking.value + + + + + + + + + + + + + + View last tracked changes + mail.tracking.value + tree,form + + + + + +
From 20bc11d7554bface7c62672c7df2cc678489f3be Mon Sep 17 00:00:00 2001 From: oca-travis Date: Sat, 23 Jun 2018 21:59:45 +0000 Subject: [PATCH 02/14] [UPD] Update mail_improved_tracking_value.pot --- .../i18n/mail_improved_tracking_value.pot | 88 +++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 mail_improved_tracking_value/i18n/mail_improved_tracking_value.pot diff --git a/mail_improved_tracking_value/i18n/mail_improved_tracking_value.pot b/mail_improved_tracking_value/i18n/mail_improved_tracking_value.pot new file mode 100644 index 000000000..22af7ba43 --- /dev/null +++ b/mail_improved_tracking_value/i18n/mail_improved_tracking_value.pot @@ -0,0 +1,88 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * mail_improved_tracking_value +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 10.0\n" +"Report-Msgid-Bugs-To: \n" +"Last-Translator: <>\n" +"Language-Team: \n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: \n" + +#. module: mail_improved_tracking_value +#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_form_view +#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list +msgid "Field changed" +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_form_view +#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list +msgid "For" +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list_filter +msgid "Group by" +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.ui.menu,name:mail_improved_tracking_value.menu_action_view_tracking_changes +msgid "Improved tracking values" +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.model,name:mail_improved_tracking_value.model_mail_tracking_value +msgid "Mail Tracking Value" +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.model.fields,field_description:mail_improved_tracking_value.field_mail_tracking_value_record_name +msgid "Message Record Name" +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.model.fields,field_description:mail_improved_tracking_value.field_mail_tracking_value_model +#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list_filter +msgid "Model" +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.model.fields,help:mail_improved_tracking_value.field_mail_tracking_value_record_name +msgid "Name get of the related document." +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.model.fields,field_description:mail_improved_tracking_value.field_mail_tracking_value_new_value_formatted +msgid "New value" +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.model.fields,field_description:mail_improved_tracking_value.field_mail_tracking_value_old_value_formatted +msgid "Old value" +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list +msgid "On" +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list_filter +msgid "Search" +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list +msgid "Tracking change list" +msgstr "" + +#. module: mail_improved_tracking_value +#: model:ir.actions.act_window,name:mail_improved_tracking_value.action_view_tracking_changes +msgid "View last tracked changes" +msgstr "" + From 3fb3480962251b17e9b2e9150d9ce006811fa94e Mon Sep 17 00:00:00 2001 From: OCA-git-bot Date: Wed, 3 Apr 2019 03:23:08 +0000 Subject: [PATCH 03/14] [ADD] icon.png --- .../static/description/icon.png | Bin 0 -> 9455 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 mail_improved_tracking_value/static/description/icon.png diff --git a/mail_improved_tracking_value/static/description/icon.png b/mail_improved_tracking_value/static/description/icon.png new file mode 100644 index 0000000000000000000000000000000000000000..3a0328b516c4980e8e44cdb63fd945757ddd132d GIT binary patch literal 9455 zcmW++2RxMjAAjx~&dlBk9S+%}OXg)AGE&Cb*&}d0jUxM@u(PQx^-s)697TX`ehR4?GS^qbkof1cslKgkU)h65qZ9Oc=ml_0temigYLJfnz{IDzUf>bGs4N!v3=Z3jMq&A#7%rM5eQ#dc?k~! zVpnB`o+K7|Al`Q_U;eD$B zfJtP*jH`siUq~{KE)`jP2|#TUEFGRryE2`i0**z#*^6~AI|YzIWy$Cu#CSLW3q=GA z6`?GZymC;dCPk~rBS%eCb`5OLr;RUZ;D`}um=H)BfVIq%7VhiMr)_#G0N#zrNH|__ zc+blN2UAB0=617@>_u;MPHN;P;N#YoE=)R#i$k_`UAA>WWCcEVMh~L_ zj--gtp&|K1#58Yz*AHCTMziU1Jzt_jG0I@qAOHsk$2}yTmVkBp_eHuY$A9)>P6o~I z%aQ?!(GqeQ-Y+b0I(m9pwgi(IIZZzsbMv+9w{PFtd_<_(LA~0H(xz{=FhLB@(1&qHA5EJw1>>=%q2f&^X>IQ{!GJ4e9U z&KlB)z(84HmNgm2hg2C0>WM{E(DdPr+EeU_N@57;PC2&DmGFW_9kP&%?X4}+xWi)( z;)z%wI5>D4a*5XwD)P--sPkoY(a~WBw;E~AW`Yue4kFa^LM3X`8x|}ZUeMnqr}>kH zG%WWW>3ml$Yez?i%)2pbKPI7?5o?hydokgQyZsNEr{a|mLdt;X2TX(#B1j35xPnPW z*bMSSOauW>o;*=kO8ojw91VX!qoOQb)zHJ!odWB}d+*K?#sY_jqPdg{Sm2HdYzdEx zOGVPhVRTGPtv0o}RfVP;Nd(|CB)I;*t&QO8h zFfekr30S!-LHmV_Su-W+rEwYXJ^;6&3|L$mMC8*bQptyOo9;>Qb9Q9`ySe3%V$A*9 zeKEe+b0{#KWGp$F+tga)0RtI)nhMa-K@JS}2krK~n8vJ=Ngm?R!9G<~RyuU0d?nz# z-5EK$o(!F?hmX*2Yt6+coY`6jGbb7tF#6nHA zuKk=GGJ;ZwON1iAfG$E#Y7MnZVmrY|j0eVI(DN_MNFJmyZ|;w4tf@=CCDZ#5N_0K= z$;R~bbk?}TpfDjfB&aiQ$VA}s?P}xPERJG{kxk5~R`iRS(SK5d+Xs9swCozZISbnS zk!)I0>t=A<-^z(cmSFz3=jZ23u13X><0b)P)^1T_))Kr`e!-pb#q&J*Q`p+B6la%C zuVl&0duN<;uOsB3%T9Fp8t{ED108<+W(nOZd?gDnfNBC3>M8WE61$So|P zVvqH0SNtDTcsUdzaMDpT=Ty0pDHHNL@Z0w$Y`XO z2M-_r1S+GaH%pz#Uy0*w$Vdl=X=rQXEzO}d6J^R6zjM1u&c9vYLvLp?W7w(?np9x1 zE_0JSAJCPB%i7p*Wvg)pn5T`8k3-uR?*NT|J`eS#_#54p>!p(mLDvmc-3o0mX*mp_ zN*AeS<>#^-{S%W<*mz^!X$w_2dHWpcJ6^j64qFBft-o}o_Vx80o0>}Du;>kLts;$8 zC`7q$QI(dKYG`Wa8#wl@V4jVWBRGQ@1dr-hstpQL)Tl+aqVpGpbSfN>5i&QMXfiZ> zaA?T1VGe?rpQ@;+pkrVdd{klI&jVS@I5_iz!=UMpTsa~mBga?1r}aRBm1WS;TT*s0f0lY=JBl66Upy)-k4J}lh=P^8(SXk~0xW=T9v*B|gzIhN z>qsO7dFd~mgxAy4V?&)=5ieYq?zi?ZEoj)&2o)RLy=@hbCRcfT5jigwtQGE{L*8<@Yd{zg;CsL5mvzfDY}P-wos_6PfprFVaeqNE%h zKZhLtcQld;ZD+>=nqN~>GvROfueSzJD&BE*}XfU|H&(FssBqY=hPCt`d zH?@s2>I(|;fcW&YM6#V#!kUIP8$Nkdh0A(bEVj``-AAyYgwY~jB zT|I7Bf@%;7aL7Wf4dZ%VqF$eiaC38OV6oy3Z#TER2G+fOCd9Iaoy6aLYbPTN{XRPz z;U!V|vBf%H!}52L2gH_+j;`bTcQRXB+y9onc^wLm5wi3-Be}U>k_u>2Eg$=k!(l@I zcCg+flakT2Nej3i0yn+g+}%NYb?ta;R?(g5SnwsQ49U8Wng8d|{B+lyRcEDvR3+`O{zfmrmvFrL6acVP%yG98X zo&+VBg@px@i)%o?dG(`T;n*$S5*rnyiR#=wW}}GsAcfyQpE|>a{=$Hjg=-*_K;UtD z#z-)AXwSRY?OPefw^iI+ z)AXz#PfEjlwTes|_{sB?4(O@fg0AJ^g8gP}ex9Ucf*@_^J(s_5jJV}c)s$`Myn|Kd z$6>}#q^n{4vN@+Os$m7KV+`}c%4)4pv@06af4-x5#wj!KKb%caK{A&Y#Rfs z-po?Dcb1({W=6FKIUirH&(yg=*6aLCekcKwyfK^JN5{wcA3nhO(o}SK#!CINhI`-I z1)6&n7O&ZmyFMuNwvEic#IiOAwNkR=u5it{B9n2sAJV5pNhar=j5`*N!Na;c7g!l$ z3aYBqUkqqTJ=Re-;)s!EOeij=7SQZ3Hq}ZRds%IM*PtM$wV z@;rlc*NRK7i3y5BETSKuumEN`Xu_8GP1Ri=OKQ$@I^ko8>H6)4rjiG5{VBM>B|%`&&s^)jS|-_95&yc=GqjNo{zFkw%%HHhS~e=s zD#sfS+-?*t|J!+ozP6KvtOl!R)@@-z24}`9{QaVLD^9VCSR2b`b!KC#o;Ki<+wXB6 zx3&O0LOWcg4&rv4QG0)4yb}7BFSEg~=IR5#ZRj8kg}dS7_V&^%#Do==#`u zpy6{ox?jWuR(;pg+f@mT>#HGWHAJRRDDDv~@(IDw&R>9643kK#HN`!1vBJHnC+RM&yIh8{gG2q zA%e*U3|N0XSRa~oX-3EAneep)@{h2vvd3Xvy$7og(sayr@95+e6~Xvi1tUqnIxoIH zVWo*OwYElb#uyW{Imam6f2rGbjR!Y3`#gPqkv57dB6K^wRGxc9B(t|aYDGS=m$&S!NmCtrMMaUg(c zc2qC=2Z`EEFMW-me5B)24AqF*bV5Dr-M5ig(l-WPS%CgaPzs6p_gnCIvTJ=Y<6!gT zVt@AfYCzjjsMEGi=rDQHo0yc;HqoRNnNFeWZgcm?f;cp(6CNylj36DoL(?TS7eU#+ z7&mfr#y))+CJOXQKUMZ7QIdS9@#-}7y2K1{8)cCt0~-X0O!O?Qx#E4Og+;A2SjalQ zs7r?qn0H044=sDN$SRG$arw~n=+T_DNdSrarmu)V6@|?1-ZB#hRn`uilTGPJ@fqEy zGt(f0B+^JDP&f=r{#Y_wi#AVDf-y!RIXU^0jXsFpf>=Ji*TeqSY!H~AMbJdCGLhC) zn7Rx+sXw6uYj;WRYrLd^5IZq@6JI1C^YkgnedZEYy<&4(z%Q$5yv#Boo{AH8n$a zhb4Y3PWdr269&?V%uI$xMcUrMzl=;w<_nm*qr=c3Rl@i5wWB;e-`t7D&c-mcQl7x! zZWB`UGcw=Y2=}~wzrfLx=uet<;m3~=8I~ZRuzvMQUQdr+yTV|ATf1Uuomr__nDf=X zZ3WYJtHp_ri(}SQAPjv+Y+0=fH4krOP@S&=zZ-t1jW1o@}z;xk8 z(Nz1co&El^HK^NrhVHa-_;&88vTU>_J33=%{if;BEY*J#1n59=07jrGQ#IP>@u#3A z;!q+E1Rj3ZJ+!4bq9F8PXJ@yMgZL;>&gYA0%_Kbi8?S=XGM~dnQZQ!yBSgcZhY96H zrWnU;k)qy`rX&&xlDyA%(a1Hhi5CWkmg(`Gb%m(HKi-7Z!LKGRP_B8@`7&hdDy5n= z`OIxqxiVfX@OX1p(mQu>0Ai*v_cTMiw4qRt3~NBvr9oBy0)r>w3p~V0SCm=An6@3n)>@z!|o-$HvDK z|3D2ZMJkLE5loMKl6R^ez@Zz%S$&mbeoqH5`Bb){Ei21q&VP)hWS2tjShfFtGE+$z zzCR$P#uktu+#!w)cX!lWN1XU%K-r=s{|j?)Akf@q#3b#{6cZCuJ~gCxuMXRmI$nGtnH+-h z+GEi!*X=AP<|fG`1>MBdTb?28JYc=fGvAi2I<$B(rs$;eoJCyR6_bc~p!XR@O-+sD z=eH`-ye})I5ic1eL~TDmtfJ|8`0VJ*Yr=hNCd)G1p2MMz4C3^Mj?7;!w|Ly%JqmuW zlIEW^Ft%z?*|fpXda>Jr^1noFZEwFgVV%|*XhH@acv8rdGxeEX{M$(vG{Zw+x(ei@ zmfXb22}8-?Fi`vo-YVrTH*C?a8%M=Hv9MqVH7H^J$KsD?>!SFZ;ZsvnHr_gn=7acz z#W?0eCdVhVMWN12VV^$>WlQ?f;P^{(&pYTops|btm6aj>_Uz+hqpGwB)vWp0Cf5y< zft8-je~nn?W11plq}N)4A{l8I7$!ks_x$PXW-2XaRFswX_BnF{R#6YIwMhAgd5F9X zGmwdadS6(a^fjHtXg8=l?Rc0Sm%hk6E9!5cLVloEy4eh(=FwgP`)~I^5~pBEWo+F6 zSf2ncyMurJN91#cJTy_u8Y}@%!bq1RkGC~-bV@SXRd4F{R-*V`bS+6;W5vZ(&+I<9$;-V|eNfLa5n-6% z2(}&uGRF;p92eS*sE*oR$@pexaqr*meB)VhmIg@h{uzkk$9~qh#cHhw#>O%)b@+(| z^IQgqzuj~Sk(J;swEM-3TrJAPCq9k^^^`q{IItKBRXYe}e0Tdr=Huf7da3$l4PdpwWDop%^}n;dD#K4s#DYA8SHZ z&1!riV4W4R7R#C))JH1~axJ)RYnM$$lIR%6fIVA@zV{XVyx}C+a-Dt8Y9M)^KU0+H zR4IUb2CJ{Hg>CuaXtD50jB(_Tcx=Z$^WYu2u5kubqmwp%drJ6 z?Fo40g!Qd<-l=TQxqHEOuPX0;^z7iX?Ke^a%XT<13TA^5`4Xcw6D@Ur&VT&CUe0d} z1GjOVF1^L@>O)l@?bD~$wzgf(nxX1OGD8fEV?TdJcZc2KoUe|oP1#=$$7ee|xbY)A zDZq+cuTpc(fFdj^=!;{k03C69lMQ(|>uhRfRu%+!k&YOi-3|1QKB z z?n?eq1XP>p-IM$Z^C;2L3itnbJZAip*Zo0aw2bs8@(s^~*8T9go!%dHcAz2lM;`yp zD=7&xjFV$S&5uDaiScyD?B-i1ze`+CoRtz`Wn+Zl&#s4&}MO{@N!ufrzjG$B79)Y2d3tBk&)TxUTw@QS0TEL_?njX|@vq?Uz(nBFK5Pq7*xj#u*R&i|?7+6# z+|r_n#SW&LXhtheZdah{ZVoqwyT{D>MC3nkFF#N)xLi{p7J1jXlmVeb;cP5?e(=f# zuT7fvjSbjS781v?7{)-X3*?>tq?)Yd)~|1{BDS(pqC zC}~H#WXlkUW*H5CDOo<)#x7%RY)A;ShGhI5s*#cRDA8YgqG(HeKDx+#(ZQ?386dv! zlXCO)w91~Vw4AmOcATuV653fa9R$fyK8ul%rG z-wfS zihugoZyr38Im?Zuh6@RcF~t1anQu7>#lPpb#}4cOA!EM11`%f*07RqOVkmX{p~KJ9 z^zP;K#|)$`^Rb{rnHGH{~>1(fawV0*Z#)}M`m8-?ZJV<+e}s9wE# z)l&az?w^5{)`S(%MRzxdNqrs1n*-=jS^_jqE*5XDrA0+VE`5^*p3CuM<&dZEeCjoz zR;uu_H9ZPZV|fQq`Cyw4nscrVwi!fE6ciMmX$!_hN7uF;jjKG)d2@aC4ropY)8etW=xJvni)8eHi`H$%#zn^WJ5NLc-rqk|u&&4Z6fD_m&JfSI1Bvb?b<*n&sfl0^t z=HnmRl`XrFvMKB%9}>PaA`m-fK6a0(8=qPkWS5bb4=v?XcWi&hRY?O5HdulRi4?fN zlsJ*N-0Qw+Yic@s0(2uy%F@ib;GjXt01Fmx5XbRo6+n|pP(&nodMoap^z{~q ziEeaUT@Mxe3vJSfI6?uLND(CNr=#^W<1b}jzW58bIfyWTDle$mmS(|x-0|2UlX+9k zQ^EX7Nw}?EzVoBfT(-LT|=9N@^hcn-_p&sqG z&*oVs2JSU+N4ZD`FhCAWaS;>|wH2G*Id|?pa#@>tyxX`+4HyIArWDvVrX)2WAOQff z0qyHu&-S@i^MS-+j--!pr4fPBj~_8({~e1bfcl0wI1kaoN>mJL6KUPQm5N7lB(ui1 zE-o%kq)&djzWJ}ob<-GfDlkB;F31j-VHKvQUGQ3sp`CwyGJk_i!y^sD0fqC@$9|jO zOqN!r!8-p==F@ZVP=U$qSpY(gQ0)59P1&t@y?5rvg<}E+GB}26NYPp4f2YFQrQtot5mn3wu_qprZ=>Ig-$ zbW26Ws~IgY>}^5w`vTB(G`PTZaDiGBo5o(tp)qli|NeV( z@H_=R8V39rt5J5YB2Ky?4eJJ#b`_iBe2ot~6%7mLt5t8Vwi^Jy7|jWXqa3amOIoRb zOr}WVFP--DsS`1WpN%~)t3R!arKF^Q$e12KEqU36AWwnCBICpH4XCsfnyrHr>$I$4 z!DpKX$OKLWarN7nv@!uIA+~RNO)l$$w}p(;b>mx8pwYvu;dD_unryX_NhT8*Tj>BTrTTL&!?O+%Rv;b?B??gSzdp?6Uug9{ zd@V08Z$BdI?fpoCS$)t4mg4rT8Q_I}h`0d-vYZ^|dOB*Q^S|xqTV*vIg?@fVFSmMpaw0qtTRbx} z({Pg?#{2`sc9)M5N$*N|4;^t$+QP?#mov zGVC@I*lBVrOU-%2y!7%)fAKjpEFsgQc4{amtiHb95KQEwvf<(3T<9-Zm$xIew#P22 zc2Ix|App^>v6(3L_MCU0d3W##AB0M~3D00EWoKZqsJYT(#@w$Y_H7G22M~ApVFTRHMI_3be)Lkn#0F*V8Pq zc}`Cjy$bE;FJ6H7p=0y#R>`}-m4(0F>%@P|?7fx{=R^uFdISRnZ2W_xQhD{YuR3t< z{6yxu=4~JkeA;|(J6_nv#>Nvs&FuLA&PW^he@t(UwFFE8)|a!R{`E`K`i^ZnyE4$k z;(749Ix|oi$c3QbEJ3b~D_kQsPz~fIUKym($a_7dJ?o+40*OLl^{=&oq$<#Q(yyrp z{J-FAniyAw9tPbe&IhQ|a`DqFTVQGQ&Gq3!C2==4x{6EJwiPZ8zub-iXoUtkJiG{} zPaR&}_fn8_z~(=;5lD-aPWD3z8PZS@AaUiomF!G8I}Mf>e~0g#BelA-5#`cj;O5>N Xviia!U7SGha1wx#SCgwmn*{w2TRX*I literal 0 HcmV?d00001 From 8b7b014df5d78ad3c7a3e709b78ecf60fbc1c672 Mon Sep 17 00:00:00 2001 From: Thierry Ducrest Date: Wed, 7 Jun 2017 15:01:30 +0200 Subject: [PATCH 04/14] [MIG] mail_improved_tracking_value: migration to Odoo 11 Improve the tracking of changed values on database fields ("mail.tracking.value" functionality) by adding many2many and one2many support. As well as a more user friendly view to consult changes recorded. --- mail_improved_tracking_value/__init__.py | 3 +- mail_improved_tracking_value/__manifest__.py | 9 ++--- .../models/mail_tracking_value.py | 29 +++++++++----- .../views/mail_tracking_value.xml | 40 +++++++++---------- 4 files changed, 40 insertions(+), 41 deletions(-) diff --git a/mail_improved_tracking_value/__init__.py b/mail_improved_tracking_value/__init__.py index 955b6c584..815d098dd 100644 --- a/mail_improved_tracking_value/__init__.py +++ b/mail_improved_tracking_value/__init__.py @@ -1,5 +1,4 @@ -# -*- coding: utf-8 -*- -# Copyright 2017 Camptocamp SA +# Copyright 2018 Camptocamp SA # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). from . import models diff --git a/mail_improved_tracking_value/__manifest__.py b/mail_improved_tracking_value/__manifest__.py index 879db4825..2b5ffda32 100644 --- a/mail_improved_tracking_value/__manifest__.py +++ b/mail_improved_tracking_value/__manifest__.py @@ -1,16 +1,15 @@ -# -*- coding: utf-8 -*- -# Copyright 2017 Camptocamp SA +# Copyright 2018 Camptocamp SA # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). { 'name': 'Improved tracking value change', - 'version': '10.0.1.0.0', + 'version': '11.0.1.0.0', 'summary': 'Improves tracking changed values for certain type of fields.' 'Adds a user-friendly view to consult them.', 'author': 'Camptocamp, Odoo Community Association (OCA)', 'license': 'AGPL-3', 'category': 'Tools', - 'website': 'http://www.camptocamp.com', + 'website': 'https://github.com/OCA/social', 'depends': [ 'base', 'mail' @@ -18,6 +17,4 @@ 'data': [ 'views/mail_tracking_value.xml' ], - 'installable': True, - 'auto_install': False, } diff --git a/mail_improved_tracking_value/models/mail_tracking_value.py b/mail_improved_tracking_value/models/mail_tracking_value.py index 3cdced2d7..d4d032d5b 100644 --- a/mail_improved_tracking_value/models/mail_tracking_value.py +++ b/mail_improved_tracking_value/models/mail_tracking_value.py @@ -1,5 +1,4 @@ -# -*- coding: utf-8 -*- -# Copyright 2017 Camptocamp SA +# Copyright 2018 Camptocamp SA # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). import json @@ -11,13 +10,22 @@ class MailTrackingValue(models.Model): _inherit = "mail.tracking.value" - new_value_formatted = fields.Char(compute='_compute_formatted_value', - string='New value') - old_value_formatted = fields.Char(compute='_compute_formatted_value', - string='Old value') - record_name = fields.Char(related='mail_message_id.record_name') - model = fields.Char(related='mail_message_id.model', store='True', - string='Model') + new_value_formatted = fields.Char( + compute='_compute_formatted_value', + string='New value', + ) + old_value_formatted = fields.Char( + compute='_compute_formatted_value', + string='Old value', + ) + record_name = fields.Char( + related='mail_message_id.record_name', + ) + model = fields.Char( + related='mail_message_id.model', + store='True', + string='Model', + ) @api.depends('new_value_char', 'new_value_integer', 'new_value_float', 'new_value_text', 'new_value_datetime', 'new_value_monetary', @@ -25,7 +33,6 @@ class MailTrackingValue(models.Model): 'old_value_text', 'old_value_datetime', 'old_value_monetary') def _compute_formatted_value(self): """ Sets the value formatted field used in the view """ - # Could be improved, by styling in the view depending on type of field for record in self: if record.field_type in ('many2many', 'one2many', 'char'): record.new_value_formatted = record.new_value_char @@ -72,7 +79,7 @@ class MailTrackingValue(models.Model): values.update(get_values(new_value, 'new')) return values else: - return super(MailTrackingValue, self).create_tracking_values( + return super().create_tracking_values( old_value, new_value, col_name, col_info ) diff --git a/mail_improved_tracking_value/views/mail_tracking_value.xml b/mail_improved_tracking_value/views/mail_tracking_value.xml index 43e74f35e..837e7a20d 100644 --- a/mail_improved_tracking_value/views/mail_tracking_value.xml +++ b/mail_improved_tracking_value/views/mail_tracking_value.xml @@ -7,12 +7,12 @@ - - - - - - + + + + + + @@ -24,16 +24,14 @@
- - - - - - - - - - + + + + + + + +
@@ -44,11 +42,9 @@ mail.tracking.value - - - - - + + + @@ -66,7 +62,7 @@ From 5c71bf0e257e19eca0eed7517cc8f703f90b68d9 Mon Sep 17 00:00:00 2001 From: mreficent Date: Mon, 22 Feb 2021 15:30:52 +0100 Subject: [PATCH 05/14] [FIX] Avoid 'Missing Record' error for one2many --- mail_improved_tracking_value/models/mail_tracking_value.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mail_improved_tracking_value/models/mail_tracking_value.py b/mail_improved_tracking_value/models/mail_tracking_value.py index d4d032d5b..f8a38710c 100644 --- a/mail_improved_tracking_value/models/mail_tracking_value.py +++ b/mail_improved_tracking_value/models/mail_tracking_value.py @@ -60,7 +60,7 @@ class MailTrackingValue(models.Model): def get_values(source, prefix): if source: - names = ', '.join(source.mapped('display_name')) + names = ', '.join(source.exists().mapped('display_name')) json_ids = json.dumps(source.ids) else: names = '' From 931e94a44b4a8fe08a8eb17d61568b066b6845ff Mon Sep 17 00:00:00 2001 From: Magno Costa Date: Mon, 22 Feb 2021 15:13:06 -0300 Subject: [PATCH 06/14] [MIG] Update version mail_improved_tracking_value module. --- mail_improved_tracking_value/__manifest__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mail_improved_tracking_value/__manifest__.py b/mail_improved_tracking_value/__manifest__.py index 2b5ffda32..e45c9ef2c 100644 --- a/mail_improved_tracking_value/__manifest__.py +++ b/mail_improved_tracking_value/__manifest__.py @@ -3,7 +3,7 @@ { 'name': 'Improved tracking value change', - 'version': '11.0.1.0.0', + 'version': '12.0.1.0.0', 'summary': 'Improves tracking changed values for certain type of fields.' 'Adds a user-friendly view to consult them.', 'author': 'Camptocamp, Odoo Community Association (OCA)', From edbeeb4286161f4bcc2d054bababeb3afb9a9418 Mon Sep 17 00:00:00 2001 From: Magno Costa Date: Mon, 22 Feb 2021 15:13:50 -0300 Subject: [PATCH 07/14] [MIG] Update signature method. --- .../models/mail_tracking_value.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mail_improved_tracking_value/models/mail_tracking_value.py b/mail_improved_tracking_value/models/mail_tracking_value.py index f8a38710c..c9271dae9 100644 --- a/mail_improved_tracking_value/models/mail_tracking_value.py +++ b/mail_improved_tracking_value/models/mail_tracking_value.py @@ -54,10 +54,10 @@ class MailTrackingValue(models.Model): record.old_value_formatted = record.old_value_text @api.model - def create_tracking_values(self, old_value, new_value, col_name, col_info): + def create_tracking_values(self, initial_value, new_value, + col_name, col_info, track_sequence): """ Add tacking capabilities for many2many and one2many fields """ if col_info['type'] in ('many2many', 'one2many'): - def get_values(source, prefix): if source: names = ', '.join(source.exists().mapped('display_name')) @@ -75,11 +75,11 @@ class MailTrackingValue(models.Model): 'field_desc': col_info['string'], 'field_type': col_info['type'], } - values.update(get_values(old_value, 'old')) + values.update(get_values(initial_value, 'old')) values.update(get_values(new_value, 'new')) return values else: return super().create_tracking_values( - old_value, new_value, - col_name, col_info + initial_value, new_value, + col_name, col_info, track_sequence ) From 8e7a0e36f5d3c4aa8a5633b5c337ea6e37b97d37 Mon Sep 17 00:00:00 2001 From: Magno Costa Date: Mon, 22 Feb 2021 15:15:35 -0300 Subject: [PATCH 08/14] [MIG] Test, method has signature changed. --- .../i18n/mail_improved_tracking_value.pot | 34 +++++++++---------- .../tests/test_improved_tracking_value.py | 7 ++-- 2 files changed, 21 insertions(+), 20 deletions(-) diff --git a/mail_improved_tracking_value/i18n/mail_improved_tracking_value.pot b/mail_improved_tracking_value/i18n/mail_improved_tracking_value.pot index 22af7ba43..dda7f9687 100644 --- a/mail_improved_tracking_value/i18n/mail_improved_tracking_value.pot +++ b/mail_improved_tracking_value/i18n/mail_improved_tracking_value.pot @@ -4,7 +4,7 @@ # msgid "" msgstr "" -"Project-Id-Version: Odoo Server 10.0\n" +"Project-Id-Version: Odoo Server 12.0\n" "Report-Msgid-Bugs-To: \n" "Last-Translator: <>\n" "Language-Team: \n" @@ -14,25 +14,25 @@ msgstr "" "Plural-Forms: \n" #. module: mail_improved_tracking_value -#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_form_view -#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list +#: model_terms:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_form_view +#: model_terms:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list msgid "Field changed" msgstr "" #. module: mail_improved_tracking_value -#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_form_view -#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list +#: model_terms:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_form_view +#: model_terms:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list msgid "For" msgstr "" #. module: mail_improved_tracking_value -#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list_filter -msgid "Group by" +#: model_terms:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list_filter +msgid "Group By" msgstr "" #. module: mail_improved_tracking_value #: model:ir.ui.menu,name:mail_improved_tracking_value.menu_action_view_tracking_changes -msgid "Improved tracking values" +msgid "Improved Tracking Values" msgstr "" #. module: mail_improved_tracking_value @@ -41,43 +41,43 @@ msgid "Mail Tracking Value" msgstr "" #. module: mail_improved_tracking_value -#: model:ir.model.fields,field_description:mail_improved_tracking_value.field_mail_tracking_value_record_name +#: model:ir.model.fields,field_description:mail_improved_tracking_value.field_mail_tracking_value__record_name msgid "Message Record Name" msgstr "" #. module: mail_improved_tracking_value -#: model:ir.model.fields,field_description:mail_improved_tracking_value.field_mail_tracking_value_model -#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list_filter +#: model:ir.model.fields,field_description:mail_improved_tracking_value.field_mail_tracking_value__model +#: model_terms:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list_filter msgid "Model" msgstr "" #. module: mail_improved_tracking_value -#: model:ir.model.fields,help:mail_improved_tracking_value.field_mail_tracking_value_record_name +#: model:ir.model.fields,help:mail_improved_tracking_value.field_mail_tracking_value__record_name msgid "Name get of the related document." msgstr "" #. module: mail_improved_tracking_value -#: model:ir.model.fields,field_description:mail_improved_tracking_value.field_mail_tracking_value_new_value_formatted +#: model:ir.model.fields,field_description:mail_improved_tracking_value.field_mail_tracking_value__new_value_formatted msgid "New value" msgstr "" #. module: mail_improved_tracking_value -#: model:ir.model.fields,field_description:mail_improved_tracking_value.field_mail_tracking_value_old_value_formatted +#: model:ir.model.fields,field_description:mail_improved_tracking_value.field_mail_tracking_value__old_value_formatted msgid "Old value" msgstr "" #. module: mail_improved_tracking_value -#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list +#: model_terms:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list msgid "On" msgstr "" #. module: mail_improved_tracking_value -#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list_filter +#: model_terms:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list_filter msgid "Search" msgstr "" #. module: mail_improved_tracking_value -#: model:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list +#: model_terms:ir.ui.view,arch_db:mail_improved_tracking_value.tracking_change_list msgid "Tracking change list" msgstr "" diff --git a/mail_improved_tracking_value/tests/test_improved_tracking_value.py b/mail_improved_tracking_value/tests/test_improved_tracking_value.py index 45c07b2d5..42a1a7f96 100644 --- a/mail_improved_tracking_value/tests/test_improved_tracking_value.py +++ b/mail_improved_tracking_value/tests/test_improved_tracking_value.py @@ -23,7 +23,7 @@ class TestImproveTrackingValue(TransactionCase): """Test tracking one2many changes""" tracking = self.model.create_tracking_values( self.mr, self.dr, 'testing_col', - {'string': 'TestingField', 'type': 'one2many'}) + {'string': 'TestingField', 'type': 'one2many'}, track_sequence=100) self.assertEqual(tracking['old_value_char'], self.mr.display_name) self.assertEqual(tracking['new_value_char'], self.dr.display_name) self.assertEqual(tracking['old_value_text'], json.dumps([self.mr.id])) @@ -33,7 +33,7 @@ class TestImproveTrackingValue(TransactionCase): """Test tracking one2many changes emtpy""" tracking = self.model.create_tracking_values( self.mr, None, 'testing_col', - {'string': 'TestingField', 'type': 'one2many'}) + {'string': 'TestingField', 'type': 'one2many'}, track_sequence=100) self.assertEqual(tracking['old_value_char'], self.mr.display_name) self.assertEqual(tracking['new_value_char'], '') self.assertEqual(tracking['old_value_text'], json.dumps([self.mr.id])) @@ -45,9 +45,10 @@ class TestImproveTrackingValue(TransactionCase): self.dr.id]) newvalue = self.env['res.partner.title'].browse([self.mm.id, self.pf.id]) + tracking = self.model.create_tracking_values( oldvalue, newvalue, 'testing_col', - {'string': 'TestingField', 'type': 'many2many'}) + {'string': 'TestingField', 'type': 'many2many'}, track_sequence=100) self.assertEqual(tracking['old_value_char'], self.mr.display_name + ', ' + self.dr.display_name) self.assertEqual(tracking['new_value_char'], From e354d77e33889598b6cbfe81e1db64fca2ccb86b Mon Sep 17 00:00:00 2001 From: Zar21 Date: Thu, 12 Aug 2021 08:40:11 +0200 Subject: [PATCH 09/14] [IMP] mail_improved_tracking_value: black, isort, prettier --- mail_improved_tracking_value/__manifest__.py | 25 +- .../models/__init__.py | 1 - .../models/mail_tracking_value.py | 75 +++--- .../tests/test_improved_tracking_value.py | 245 ++++++++++-------- .../views/mail_tracking_value.xml | 54 ++-- 5 files changed, 221 insertions(+), 179 deletions(-) diff --git a/mail_improved_tracking_value/__manifest__.py b/mail_improved_tracking_value/__manifest__.py index e45c9ef2c..db9841acc 100644 --- a/mail_improved_tracking_value/__manifest__.py +++ b/mail_improved_tracking_value/__manifest__.py @@ -2,19 +2,14 @@ # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). { - 'name': 'Improved tracking value change', - 'version': '12.0.1.0.0', - 'summary': 'Improves tracking changed values for certain type of fields.' - 'Adds a user-friendly view to consult them.', - 'author': 'Camptocamp, Odoo Community Association (OCA)', - 'license': 'AGPL-3', - 'category': 'Tools', - 'website': 'https://github.com/OCA/social', - 'depends': [ - 'base', - 'mail' - ], - 'data': [ - 'views/mail_tracking_value.xml' - ], + "name": "Improved tracking value change", + "version": "12.0.1.0.0", + "summary": "Improves tracking changed values for certain type of fields." + "Adds a user-friendly view to consult them.", + "author": "Camptocamp, Odoo Community Association (OCA)", + "license": "AGPL-3", + "category": "Tools", + "website": "https://github.com/OCA/social", + "depends": ["base", "mail"], + "data": ["views/mail_tracking_value.xml"], } diff --git a/mail_improved_tracking_value/models/__init__.py b/mail_improved_tracking_value/models/__init__.py index fa64a900e..5185fc854 100644 --- a/mail_improved_tracking_value/models/__init__.py +++ b/mail_improved_tracking_value/models/__init__.py @@ -1,4 +1,3 @@ -# -*- coding: utf-8 -*- # Copyright 2017 Camptocamp SA # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). diff --git a/mail_improved_tracking_value/models/mail_tracking_value.py b/mail_improved_tracking_value/models/mail_tracking_value.py index c9271dae9..746ac8c24 100644 --- a/mail_improved_tracking_value/models/mail_tracking_value.py +++ b/mail_improved_tracking_value/models/mail_tracking_value.py @@ -11,75 +11,86 @@ class MailTrackingValue(models.Model): _inherit = "mail.tracking.value" new_value_formatted = fields.Char( - compute='_compute_formatted_value', - string='New value', + compute="_compute_formatted_value", + string="New value", ) old_value_formatted = fields.Char( - compute='_compute_formatted_value', - string='Old value', + compute="_compute_formatted_value", + string="Old value", ) record_name = fields.Char( - related='mail_message_id.record_name', + related="mail_message_id.record_name", ) model = fields.Char( - related='mail_message_id.model', - store='True', - string='Model', + related="mail_message_id.model", + store="True", + string="Model", ) - @api.depends('new_value_char', 'new_value_integer', 'new_value_float', - 'new_value_text', 'new_value_datetime', 'new_value_monetary', - 'old_value_char', 'old_value_integer', 'old_value_float', - 'old_value_text', 'old_value_datetime', 'old_value_monetary') + @api.depends( + "new_value_char", + "new_value_integer", + "new_value_float", + "new_value_text", + "new_value_datetime", + "new_value_monetary", + "old_value_char", + "old_value_integer", + "old_value_float", + "old_value_text", + "old_value_datetime", + "old_value_monetary", + ) def _compute_formatted_value(self): """ Sets the value formatted field used in the view """ for record in self: - if record.field_type in ('many2many', 'one2many', 'char'): + if record.field_type in ("many2many", "one2many", "char"): record.new_value_formatted = record.new_value_char record.old_value_formatted = record.old_value_char - elif record.field_type == 'integer': + elif record.field_type == "integer": record.new_value_formatted = str(record.new_value_integer) record.old_value_formatted = str(record.old_value_integer) - elif record.field_type == 'float': + elif record.field_type == "float": record.new_value_formatted = str(record.new_value_float) record.old_value_formatted = str(record.old_value_float) - elif record.field_type == 'monetary': + elif record.field_type == "monetary": record.new_value_formatted = str(record.new_value_monetary) record.old_value_formatted = str(record.old_value_monetary) - elif record.field_type == 'datetime': + elif record.field_type == "datetime": record.new_value_formatted = str(record.new_value_datetime) record.old_value_formatted = str(record.old_value_datetime) - elif record.field_type == 'text': + elif record.field_type == "text": record.new_value_formatted = record.new_value_text record.old_value_formatted = record.old_value_text @api.model - def create_tracking_values(self, initial_value, new_value, - col_name, col_info, track_sequence): + def create_tracking_values( + self, initial_value, new_value, col_name, col_info, track_sequence + ): """ Add tacking capabilities for many2many and one2many fields """ - if col_info['type'] in ('many2many', 'one2many'): + if col_info["type"] in ("many2many", "one2many"): + def get_values(source, prefix): if source: - names = ', '.join(source.exists().mapped('display_name')) + names = ", ".join(source.exists().mapped("display_name")) json_ids = json.dumps(source.ids) else: - names = '' + names = "" json_ids = json.dumps([]) return { - '{}_value_char'.format(prefix): names, - '{}_value_text'.format(prefix): json_ids, + "{}_value_char".format(prefix): names, + "{}_value_text".format(prefix): json_ids, } values = { - 'field': col_name, - 'field_desc': col_info['string'], - 'field_type': col_info['type'], + "field": col_name, + "field_desc": col_info["string"], + "field_type": col_info["type"], } - values.update(get_values(initial_value, 'old')) - values.update(get_values(new_value, 'new')) + values.update(get_values(initial_value, "old")) + values.update(get_values(new_value, "new")) return values else: return super().create_tracking_values( - initial_value, new_value, - col_name, col_info, track_sequence + initial_value, new_value, col_name, col_info, track_sequence ) diff --git a/mail_improved_tracking_value/tests/test_improved_tracking_value.py b/mail_improved_tracking_value/tests/test_improved_tracking_value.py index 42a1a7f96..366d0149e 100644 --- a/mail_improved_tracking_value/tests/test_improved_tracking_value.py +++ b/mail_improved_tracking_value/tests/test_improved_tracking_value.py @@ -1,155 +1,180 @@ -# -*- coding: utf-8 -*- # Copyright 2018 Camptocamp SA # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html) import json + from odoo.tests.common import TransactionCase class TestImproveTrackingValue(TransactionCase): - def setUp(self): super(TestImproveTrackingValue, self).setUp() - self.model = self.env['mail.tracking.value'] - self.msg = self.env['mail.message'].create({ - 'message_type': 'email' - }) - self.mr = self.env.ref('base.res_partner_title_mister') - self.dr = self.env.ref('base.res_partner_title_doctor') - self.mm = self.env.ref('base.res_partner_title_madam') - self.pf = self.env.ref('base.res_partner_title_prof') + self.model = self.env["mail.tracking.value"] + self.msg = self.env["mail.message"].create({"message_type": "email"}) + self.mr = self.env.ref("base.res_partner_title_mister") + self.dr = self.env.ref("base.res_partner_title_doctor") + self.mm = self.env.ref("base.res_partner_title_madam") + self.pf = self.env.ref("base.res_partner_title_prof") def test_change_one2many(self): """Test tracking one2many changes""" tracking = self.model.create_tracking_values( - self.mr, self.dr, 'testing_col', - {'string': 'TestingField', 'type': 'one2many'}, track_sequence=100) - self.assertEqual(tracking['old_value_char'], self.mr.display_name) - self.assertEqual(tracking['new_value_char'], self.dr.display_name) - self.assertEqual(tracking['old_value_text'], json.dumps([self.mr.id])) - self.assertEqual(tracking['new_value_text'], json.dumps([self.dr.id])) + self.mr, + self.dr, + "testing_col", + {"string": "TestingField", "type": "one2many"}, + track_sequence=100, + ) + self.assertEqual(tracking["old_value_char"], self.mr.display_name) + self.assertEqual(tracking["new_value_char"], self.dr.display_name) + self.assertEqual(tracking["old_value_text"], json.dumps([self.mr.id])) + self.assertEqual(tracking["new_value_text"], json.dumps([self.dr.id])) def test_change_one2many_empty(self): """Test tracking one2many changes emtpy""" tracking = self.model.create_tracking_values( - self.mr, None, 'testing_col', - {'string': 'TestingField', 'type': 'one2many'}, track_sequence=100) - self.assertEqual(tracking['old_value_char'], self.mr.display_name) - self.assertEqual(tracking['new_value_char'], '') - self.assertEqual(tracking['old_value_text'], json.dumps([self.mr.id])) - self.assertEqual(tracking['new_value_text'], json.dumps([])) + self.mr, + None, + "testing_col", + {"string": "TestingField", "type": "one2many"}, + track_sequence=100, + ) + self.assertEqual(tracking["old_value_char"], self.mr.display_name) + self.assertEqual(tracking["new_value_char"], "") + self.assertEqual(tracking["old_value_text"], json.dumps([self.mr.id])) + self.assertEqual(tracking["new_value_text"], json.dumps([])) def test_change_many2many(self): """Test tracking many2many changes""" - oldvalue = self.env['res.partner.title'].browse([self.mr.id, - self.dr.id]) - newvalue = self.env['res.partner.title'].browse([self.mm.id, - self.pf.id]) + oldvalue = self.env["res.partner.title"].browse([self.mr.id, self.dr.id]) + newvalue = self.env["res.partner.title"].browse([self.mm.id, self.pf.id]) tracking = self.model.create_tracking_values( - oldvalue, newvalue, 'testing_col', - {'string': 'TestingField', 'type': 'many2many'}, track_sequence=100) - self.assertEqual(tracking['old_value_char'], - self.mr.display_name + ', ' + self.dr.display_name) - self.assertEqual(tracking['new_value_char'], - self.mm.display_name + ', ' + self.pf.display_name) - self.assertEqual(tracking['old_value_text'], - json.dumps(oldvalue.ids)) - self.assertEqual(tracking['new_value_text'], - json.dumps(newvalue.ids)) + oldvalue, + newvalue, + "testing_col", + {"string": "TestingField", "type": "many2many"}, + track_sequence=100, + ) + self.assertEqual( + tracking["old_value_char"], + self.mr.display_name + ", " + self.dr.display_name, + ) + self.assertEqual( + tracking["new_value_char"], + self.mm.display_name + ", " + self.pf.display_name, + ) + self.assertEqual(tracking["old_value_text"], json.dumps(oldvalue.ids)) + self.assertEqual(tracking["new_value_text"], json.dumps(newvalue.ids)) def test_char_tracking_value(self): - r = self.model.create({ - 'mail_message_id': self.msg.id, - 'field_type': 'char', - 'old_value_char': 'weakness', - 'new_value_char': 'strength', - 'field': 'test', - 'field_desc': 'desc', - }) - self.assertEqual(r.old_value_formatted, 'weakness') - self.assertEqual(r.new_value_formatted, 'strength') + r = self.model.create( + { + "mail_message_id": self.msg.id, + "field_type": "char", + "old_value_char": "weakness", + "new_value_char": "strength", + "field": "test", + "field_desc": "desc", + } + ) + self.assertEqual(r.old_value_formatted, "weakness") + self.assertEqual(r.new_value_formatted, "strength") def test_many2many_tracking_value(self): - r = self.model.create({ - 'mail_message_id': self.msg.id, - 'field_type': 'many2many', - 'old_value_char': '123', - 'new_value_char': '456', - 'field': 'test', - 'field_desc': 'desc', - }) - self.assertEqual(r.old_value_formatted, '123') - self.assertEqual(r.new_value_formatted, '456') + r = self.model.create( + { + "mail_message_id": self.msg.id, + "field_type": "many2many", + "old_value_char": "123", + "new_value_char": "456", + "field": "test", + "field_desc": "desc", + } + ) + self.assertEqual(r.old_value_formatted, "123") + self.assertEqual(r.new_value_formatted, "456") def test_one2many_tracking_value(self): - r = self.model.create({ - 'mail_message_id': self.msg.id, - 'field_type': 'one2many', - 'old_value_char': '123', - 'new_value_char': '456', - 'field': 'test', - 'field_desc': 'desc', - }) - self.assertEqual(r.old_value_formatted, '123') - self.assertEqual(r.new_value_formatted, '456') + r = self.model.create( + { + "mail_message_id": self.msg.id, + "field_type": "one2many", + "old_value_char": "123", + "new_value_char": "456", + "field": "test", + "field_desc": "desc", + } + ) + self.assertEqual(r.old_value_formatted, "123") + self.assertEqual(r.new_value_formatted, "456") def test_integer_tracking_value(self): - r = self.model.create({ - 'mail_message_id': self.msg.id, - 'field_type': 'integer', - 'old_value_integer': 1, - 'new_value_integer': 3, - 'field': 'test', - 'field_desc': 'desc', - }) + r = self.model.create( + { + "mail_message_id": self.msg.id, + "field_type": "integer", + "old_value_integer": 1, + "new_value_integer": 3, + "field": "test", + "field_desc": "desc", + } + ) self.assertEqual(r.old_value_formatted, str(1)) self.assertEqual(r.new_value_formatted, str(3)) def test_float_tracking_value(self): - r = self.model.create({ - 'mail_message_id': self.msg.id, - 'field_type': 'float', - 'old_value_float': 1.1, - 'new_value_float': 3.14159, - 'field': 'test', - 'field_desc': 'desc', - }) + r = self.model.create( + { + "mail_message_id": self.msg.id, + "field_type": "float", + "old_value_float": 1.1, + "new_value_float": 3.14159, + "field": "test", + "field_desc": "desc", + } + ) self.assertEqual(r.old_value_formatted, str(1.1)) self.assertEqual(r.new_value_formatted, str(3.14159)) def test_monetary_tracking_value(self): - r = self.model.create({ - 'mail_message_id': self.msg.id, - 'field_type': 'monetary', - 'old_value_monetary': 3.45, - 'new_value_monetary': 5.45, - 'field': 'test', - 'field_desc': 'desc', - }) + r = self.model.create( + { + "mail_message_id": self.msg.id, + "field_type": "monetary", + "old_value_monetary": 3.45, + "new_value_monetary": 5.45, + "field": "test", + "field_desc": "desc", + } + ) self.assertEqual(r.old_value_formatted, str(3.45)) self.assertEqual(r.new_value_formatted, str(5.45)) def test_datetime_tracking_value(self): - r = self.model.create({ - 'mail_message_id': self.msg.id, - 'field_type': 'datetime', - 'old_value_datetime': '2018-01-01', - 'new_value_datetime': '2018-01-04', - 'field': 'test', - 'field_desc': 'desc', - }) - self.assertEqual(r.old_value_formatted, '2018-01-01 00:00:00') - self.assertEqual(r.new_value_formatted, '2018-01-04 00:00:00') + r = self.model.create( + { + "mail_message_id": self.msg.id, + "field_type": "datetime", + "old_value_datetime": "2018-01-01", + "new_value_datetime": "2018-01-04", + "field": "test", + "field_desc": "desc", + } + ) + self.assertEqual(r.old_value_formatted, "2018-01-01 00:00:00") + self.assertEqual(r.new_value_formatted, "2018-01-04 00:00:00") def test_text_tracking_value(self): - r = self.model.create({ - 'mail_message_id': self.msg.id, - 'field_type': 'text', - 'old_value_text': 'previous', - 'new_value_text': 'next', - 'field': 'test', - 'field_desc': 'desc', - }) - self.assertEqual(r.old_value_formatted, 'previous') - self.assertEqual(r.new_value_formatted, 'next') + r = self.model.create( + { + "mail_message_id": self.msg.id, + "field_type": "text", + "old_value_text": "previous", + "new_value_text": "next", + "field": "test", + "field_desc": "desc", + } + ) + self.assertEqual(r.old_value_formatted, "previous") + self.assertEqual(r.new_value_formatted, "next") diff --git a/mail_improved_tracking_value/views/mail_tracking_value.xml b/mail_improved_tracking_value/views/mail_tracking_value.xml index 837e7a20d..58ff24bb4 100644 --- a/mail_improved_tracking_value/views/mail_tracking_value.xml +++ b/mail_improved_tracking_value/views/mail_tracking_value.xml @@ -1,18 +1,23 @@ - + Tracking change list" mail.tracking.value - - - - - - - + + + + + + + @@ -20,17 +25,17 @@ Tracking change form mail.tracking.value - +
- + - - - - - + + + + +
@@ -42,9 +47,13 @@ mail.tracking.value - + - + @@ -54,14 +63,17 @@ View last tracked changes mail.tracking.value tree,form -
- Date: Thu, 12 Aug 2021 09:48:33 +0200 Subject: [PATCH 10/14] [MIG] mail_improved_tracking_value: Migration to 14.0 --- mail_improved_tracking_value/__manifest__.py | 2 +- .../models/mail_tracking_value.py | 37 +++++++++++-------- .../tests/test_improved_tracking_value.py | 31 +++++++++------- 3 files changed, 40 insertions(+), 30 deletions(-) diff --git a/mail_improved_tracking_value/__manifest__.py b/mail_improved_tracking_value/__manifest__.py index db9841acc..e1001f198 100644 --- a/mail_improved_tracking_value/__manifest__.py +++ b/mail_improved_tracking_value/__manifest__.py @@ -3,7 +3,7 @@ { "name": "Improved tracking value change", - "version": "12.0.1.0.0", + "version": "14.0.1.0.0", "summary": "Improves tracking changed values for certain type of fields." "Adds a user-friendly view to consult them.", "author": "Camptocamp, Odoo Community Association (OCA)", diff --git a/mail_improved_tracking_value/models/mail_tracking_value.py b/mail_improved_tracking_value/models/mail_tracking_value.py index 746ac8c24..a66d3a4bc 100644 --- a/mail_improved_tracking_value/models/mail_tracking_value.py +++ b/mail_improved_tracking_value/models/mail_tracking_value.py @@ -11,21 +11,13 @@ class MailTrackingValue(models.Model): _inherit = "mail.tracking.value" new_value_formatted = fields.Char( - compute="_compute_formatted_value", - string="New value", + compute="_compute_formatted_value", string="New value" ) old_value_formatted = fields.Char( - compute="_compute_formatted_value", - string="Old value", - ) - record_name = fields.Char( - related="mail_message_id.record_name", - ) - model = fields.Char( - related="mail_message_id.model", - store="True", - string="Model", + compute="_compute_formatted_value", string="Old value" ) + record_name = fields.Char(related="mail_message_id.record_name") + model = fields.Char(related="mail_message_id.model", store="True", string="Model") @api.depends( "new_value_char", @@ -65,7 +57,13 @@ class MailTrackingValue(models.Model): @api.model def create_tracking_values( - self, initial_value, new_value, col_name, col_info, track_sequence + self, + initial_value, + new_value, + col_name, + col_info, + tracking_sequence, + model_name, ): """ Add tacking capabilities for many2many and one2many fields """ if col_info["type"] in ("many2many", "one2many"): @@ -82,8 +80,12 @@ class MailTrackingValue(models.Model): "{}_value_text".format(prefix): json_ids, } + field = self.env["ir.model.fields"]._get(model_name, col_name) + if not field: + return + values = { - "field": col_name, + "field": field.id, "field_desc": col_info["string"], "field_type": col_info["type"], } @@ -92,5 +94,10 @@ class MailTrackingValue(models.Model): return values else: return super().create_tracking_values( - initial_value, new_value, col_name, col_info, track_sequence + initial_value, + new_value, + col_name, + col_info, + tracking_sequence, + model_name, ) diff --git a/mail_improved_tracking_value/tests/test_improved_tracking_value.py b/mail_improved_tracking_value/tests/test_improved_tracking_value.py index 366d0149e..d796dbcf6 100644 --- a/mail_improved_tracking_value/tests/test_improved_tracking_value.py +++ b/mail_improved_tracking_value/tests/test_improved_tracking_value.py @@ -21,9 +21,10 @@ class TestImproveTrackingValue(TransactionCase): tracking = self.model.create_tracking_values( self.mr, self.dr, - "testing_col", + "title", {"string": "TestingField", "type": "one2many"}, - track_sequence=100, + tracking_sequence=100, + model_name="res.partner", ) self.assertEqual(tracking["old_value_char"], self.mr.display_name) self.assertEqual(tracking["new_value_char"], self.dr.display_name) @@ -35,9 +36,10 @@ class TestImproveTrackingValue(TransactionCase): tracking = self.model.create_tracking_values( self.mr, None, - "testing_col", + "title", {"string": "TestingField", "type": "one2many"}, - track_sequence=100, + tracking_sequence=100, + model_name="res.partner", ) self.assertEqual(tracking["old_value_char"], self.mr.display_name) self.assertEqual(tracking["new_value_char"], "") @@ -52,9 +54,10 @@ class TestImproveTrackingValue(TransactionCase): tracking = self.model.create_tracking_values( oldvalue, newvalue, - "testing_col", + "title", {"string": "TestingField", "type": "many2many"}, - track_sequence=100, + tracking_sequence=100, + model_name="res.partner", ) self.assertEqual( tracking["old_value_char"], @@ -74,7 +77,7 @@ class TestImproveTrackingValue(TransactionCase): "field_type": "char", "old_value_char": "weakness", "new_value_char": "strength", - "field": "test", + "field": self.env["ir.model.fields"]._get("res.partner", "name").id, "field_desc": "desc", } ) @@ -88,7 +91,7 @@ class TestImproveTrackingValue(TransactionCase): "field_type": "many2many", "old_value_char": "123", "new_value_char": "456", - "field": "test", + "field": self.env["ir.model.fields"]._get("res.partner", "name").id, "field_desc": "desc", } ) @@ -102,7 +105,7 @@ class TestImproveTrackingValue(TransactionCase): "field_type": "one2many", "old_value_char": "123", "new_value_char": "456", - "field": "test", + "field": self.env["ir.model.fields"]._get("res.partner", "name").id, "field_desc": "desc", } ) @@ -116,7 +119,7 @@ class TestImproveTrackingValue(TransactionCase): "field_type": "integer", "old_value_integer": 1, "new_value_integer": 3, - "field": "test", + "field": self.env["ir.model.fields"]._get("res.partner", "name").id, "field_desc": "desc", } ) @@ -130,7 +133,7 @@ class TestImproveTrackingValue(TransactionCase): "field_type": "float", "old_value_float": 1.1, "new_value_float": 3.14159, - "field": "test", + "field": self.env["ir.model.fields"]._get("res.partner", "name").id, "field_desc": "desc", } ) @@ -144,7 +147,7 @@ class TestImproveTrackingValue(TransactionCase): "field_type": "monetary", "old_value_monetary": 3.45, "new_value_monetary": 5.45, - "field": "test", + "field": self.env["ir.model.fields"]._get("res.partner", "name").id, "field_desc": "desc", } ) @@ -158,7 +161,7 @@ class TestImproveTrackingValue(TransactionCase): "field_type": "datetime", "old_value_datetime": "2018-01-01", "new_value_datetime": "2018-01-04", - "field": "test", + "field": self.env["ir.model.fields"]._get("res.partner", "name").id, "field_desc": "desc", } ) @@ -172,7 +175,7 @@ class TestImproveTrackingValue(TransactionCase): "field_type": "text", "old_value_text": "previous", "new_value_text": "next", - "field": "test", + "field": self.env["ir.model.fields"]._get("res.partner", "name").id, "field_desc": "desc", } ) From b0e69372323f46aacc778bc232c00b25c46d68ca Mon Sep 17 00:00:00 2001 From: duyanh Date: Tue, 27 Sep 2022 10:25:39 +0700 Subject: [PATCH 11/14] [15.0][MIG] mail_improved_tracking_value: Migration to 15.0 --- mail_improved_tracking_value/__manifest__.py | 2 +- mail_improved_tracking_value/models/mail_tracking_value.py | 6 +++--- mail_improved_tracking_value/views/mail_tracking_value.xml | 1 - 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/mail_improved_tracking_value/__manifest__.py b/mail_improved_tracking_value/__manifest__.py index e1001f198..656ce9bbc 100644 --- a/mail_improved_tracking_value/__manifest__.py +++ b/mail_improved_tracking_value/__manifest__.py @@ -3,7 +3,7 @@ { "name": "Improved tracking value change", - "version": "14.0.1.0.0", + "version": "15.0.1.0.0", "summary": "Improves tracking changed values for certain type of fields." "Adds a user-friendly view to consult them.", "author": "Camptocamp, Odoo Community Association (OCA)", diff --git a/mail_improved_tracking_value/models/mail_tracking_value.py b/mail_improved_tracking_value/models/mail_tracking_value.py index a66d3a4bc..e06531058 100644 --- a/mail_improved_tracking_value/models/mail_tracking_value.py +++ b/mail_improved_tracking_value/models/mail_tracking_value.py @@ -1,4 +1,4 @@ -# Copyright 2018 Camptocamp SA +# Copyright 2018-2022 Camptocamp SA # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). import json @@ -34,7 +34,7 @@ class MailTrackingValue(models.Model): "old_value_monetary", ) def _compute_formatted_value(self): - """ Sets the value formatted field used in the view """ + """Sets the value formatted field used in the view""" for record in self: if record.field_type in ("many2many", "one2many", "char"): record.new_value_formatted = record.new_value_char @@ -65,7 +65,7 @@ class MailTrackingValue(models.Model): tracking_sequence, model_name, ): - """ Add tacking capabilities for many2many and one2many fields """ + """Add tacking capabilities for many2many and one2many fields""" if col_info["type"] in ("many2many", "one2many"): def get_values(source, prefix): diff --git a/mail_improved_tracking_value/views/mail_tracking_value.xml b/mail_improved_tracking_value/views/mail_tracking_value.xml index 58ff24bb4..a8003bf44 100644 --- a/mail_improved_tracking_value/views/mail_tracking_value.xml +++ b/mail_improved_tracking_value/views/mail_tracking_value.xml @@ -6,7 +6,6 @@ mail.tracking.value Date: Mon, 9 Jan 2023 15:22:34 +0700 Subject: [PATCH 12/14] Add show message id if display_name null --- .../models/__init__.py | 1 + .../models/mail_message.py | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 mail_improved_tracking_value/models/mail_message.py diff --git a/mail_improved_tracking_value/models/__init__.py b/mail_improved_tracking_value/models/__init__.py index 5185fc854..7995570df 100644 --- a/mail_improved_tracking_value/models/__init__.py +++ b/mail_improved_tracking_value/models/__init__.py @@ -2,3 +2,4 @@ # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). from . import mail_tracking_value +from . import mail_message diff --git a/mail_improved_tracking_value/models/mail_message.py b/mail_improved_tracking_value/models/mail_message.py new file mode 100644 index 000000000..581541007 --- /dev/null +++ b/mail_improved_tracking_value/models/mail_message.py @@ -0,0 +1,19 @@ +from odoo import api, models + + +class MailMessage(models.Model): + _inherit = "mail.message" + + @api.model + def name_get(self): + res = super(MailMessage, self).name_get() + params = self.env.context.get("params") + if params: + model = params.get("model") + view_type = params.get("view_type") + if model == "mail.tracking.value" and view_type == "form": + for rec in res: + if rec[1] == "False": + new_name = (rec[0], "Message ID - " + str(rec[0])) + res[res.index(rec)] = new_name + return res From 280f325c33ec19a8e1ebeb320ebbdf5f9dbef3c1 Mon Sep 17 00:00:00 2001 From: Anna Janiszewska Date: Mon, 12 Jun 2023 11:07:26 +0200 Subject: [PATCH 13/14] [IMP] mail_improved_tracking_value: pre-commit stuff --- .../odoo/addons/mail_improved_tracking_value | 1 + setup/mail_improved_tracking_value/setup.py | 6 ++++++ 2 files changed, 7 insertions(+) create mode 120000 setup/mail_improved_tracking_value/odoo/addons/mail_improved_tracking_value create mode 100644 setup/mail_improved_tracking_value/setup.py diff --git a/setup/mail_improved_tracking_value/odoo/addons/mail_improved_tracking_value b/setup/mail_improved_tracking_value/odoo/addons/mail_improved_tracking_value new file mode 120000 index 000000000..c2c25e490 --- /dev/null +++ b/setup/mail_improved_tracking_value/odoo/addons/mail_improved_tracking_value @@ -0,0 +1 @@ +../../../../mail_improved_tracking_value \ No newline at end of file diff --git a/setup/mail_improved_tracking_value/setup.py b/setup/mail_improved_tracking_value/setup.py new file mode 100644 index 000000000..28c57bb64 --- /dev/null +++ b/setup/mail_improved_tracking_value/setup.py @@ -0,0 +1,6 @@ +import setuptools + +setuptools.setup( + setup_requires=['setuptools-odoo'], + odoo_addon=True, +) From 991ff000a8d67bd0fde6c4c10d6726c6bc0d7000 Mon Sep 17 00:00:00 2001 From: Anna Janiszewska Date: Mon, 12 Jun 2023 11:07:55 +0200 Subject: [PATCH 14/14] [MIG] mail_improved_tracking_value: Migration to 16.0 --- mail_improved_tracking_value/__manifest__.py | 2 +- .../tests/test_improved_tracking_value.py | 17 +++++++++-------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/mail_improved_tracking_value/__manifest__.py b/mail_improved_tracking_value/__manifest__.py index 656ce9bbc..5b34184ca 100644 --- a/mail_improved_tracking_value/__manifest__.py +++ b/mail_improved_tracking_value/__manifest__.py @@ -3,7 +3,7 @@ { "name": "Improved tracking value change", - "version": "15.0.1.0.0", + "version": "16.0.1.0.0", "summary": "Improves tracking changed values for certain type of fields." "Adds a user-friendly view to consult them.", "author": "Camptocamp, Odoo Community Association (OCA)", diff --git a/mail_improved_tracking_value/tests/test_improved_tracking_value.py b/mail_improved_tracking_value/tests/test_improved_tracking_value.py index d796dbcf6..652c127b3 100644 --- a/mail_improved_tracking_value/tests/test_improved_tracking_value.py +++ b/mail_improved_tracking_value/tests/test_improved_tracking_value.py @@ -7,14 +7,15 @@ from odoo.tests.common import TransactionCase class TestImproveTrackingValue(TransactionCase): - def setUp(self): - super(TestImproveTrackingValue, self).setUp() - self.model = self.env["mail.tracking.value"] - self.msg = self.env["mail.message"].create({"message_type": "email"}) - self.mr = self.env.ref("base.res_partner_title_mister") - self.dr = self.env.ref("base.res_partner_title_doctor") - self.mm = self.env.ref("base.res_partner_title_madam") - self.pf = self.env.ref("base.res_partner_title_prof") + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.model = cls.env["mail.tracking.value"] + cls.msg = cls.env["mail.message"].create({"message_type": "email"}) + cls.mr = cls.env.ref("base.res_partner_title_mister") + cls.dr = cls.env.ref("base.res_partner_title_doctor") + cls.mm = cls.env.ref("base.res_partner_title_madam") + cls.pf = cls.env.ref("base.res_partner_title_prof") def test_change_one2many(self): """Test tracking one2many changes"""