Techsystech
/
server-tools
mirror of https://github.com/OCA/server-tools.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[FIX] don't rollback() transation, use savepoint. This fixes concurrency 

issues with long running cron threads as rollback also releases the lock
pull/3071/head
Holger Brunn 2013-04-18 16:43:25 +02:00 committed by Jose Zambudio
parent bec5ca112b
commit fe1379c3be
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fetchmail_attach_from_folder/model/fetchmail_server.py
View File

@ -148,14 +148,15 @@ class fetchmail_server(Model):
if found_ids and (len(found_ids) == 1 or if found_ids and (len(found_ids) == 1 or
folder.match_first): folder.match_first):
try: try:
cr.execute('savepoint apply_matching')
match_algorithm.handle_match( match_algorithm.handle_match(
cr, uid, connection, cr, uid, connection,
found_ids[0], folder, mail_message, found_ids[0], folder, mail_message,
msgdata[0][1], msgid, context) msgdata[0][1], msgid, context)
cr.commit() cr.execute('release savepoint apply_matching')
matched_object_ids += found_ids[:1] matched_object_ids += found_ids[:1]
except Exception, e: except Exception, e:
cr.rollback() cr.execute('rollback to savepoint apply_matching')
logger.exception( logger.exception(
"Failed to fetch mail %s from %s", "Failed to fetch mail %s from %s",
msgid, this.name) msgid, this.name)