Techsystech
/
server-tools
mirror of https://github.com/OCA/server-tools.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[FIX] auditlog: autovacuum performance 

Add database indices on the foreign key fields of the auditlog models.
Without these indices, the performance of the autovacuum cron are terrible
because the "ON DELETE SET NULL" trigger has to make a full table scan
on the auditlog_log and auditlog_log_line tables when
auditlog_http_session and auditlog_http_request rows are deleted.
pull/2445/head
Alexandre Fayolle 2022-10-31 12:41:58 +01:00
parent 47d914f73f
commit db8463fe78
2 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
auditlog/models/http_request.py
View File

@ -16,7 +16,9 @@ class AuditlogHTTPRequest(models.Model):
name = fields.Char("Path")
root_url = fields.Char("Root URL")
user_id = fields.Many2one("res.users", string="User")
http_session_id = fields.Many2one("auditlog.http.session", string="Session")
http_session_id = fields.Many2one(
"auditlog.http.session", string="Session", index=True
)
user_context = fields.Char("Context")
log_ids = fields.One2many("auditlog.log", "http_request_id", string="Logs")

16
auditlog/models/log.py
View File

@ -19,8 +19,12 @@ class AuditlogLog(models.Model):
user_id = fields.Many2one("res.users", string="User")
method = fields.Char(size=64)
line_ids = fields.One2many("auditlog.log.line", "log_id", string="Fields updated")
http_session_id = fields.Many2one("auditlog.http.session", string="Session")
http_request_id = fields.Many2one("auditlog.http.request", string="HTTP Request")
http_session_id = fields.Many2one(
"auditlog.http.session", string="Session", index=True
)
http_request_id = fields.Many2one(
"auditlog.http.request", string="HTTP Request", index=True
)
log_type = fields.Selection(
[("full", "Full log"), ("fast", "Fast log")], string="Type"
)
@ -70,8 +74,12 @@ class AuditlogLogLine(models.Model):
res_id = fields.Integer(related="log_id.res_id", store=True)
user_id = fields.Many2one(related="log_id.user_id", store=True)
method = fields.Char(related="log_id.method", store=True)
http_session_id = fields.Many2one(related="log_id.http_session_id", store=True)
http_request_id = fields.Many2one(related="log_id.http_request_id", store=True)
http_session_id = fields.Many2one(
related="log_id.http_session_id", store=True, index=True
)
http_request_id = fields.Many2one(
related="log_id.http_request_id", store=True, index=True
)
log_type = fields.Selection(related="log_id.log_type", store=True)
@api.model_create_multi