[FIX] upgrade_analysis: Proper UI in forms

The colspan property of some UI elements were not correctly adjusted to
the v16 sytem.

This commits fixes it.

upgrade_analysis/tests/test_module.py

@@ -21,19 +21,11 @@ class TestUpgradeAnalysis(common.TransactionCase):
             self.website_module.id in wizard.module_ids.ids,
             "Select Odoo module should select 'product' module",
         )
-        # New patch avoids to reinstall already installed modules, so this will fail
-        # wizard.select_oca_modules()
-        # self.assertTrue(
-        #     self.upgrade_analysis.id in wizard.module_ids.ids,
-        #     "Select OCA module should select 'upgrade_analysis' module",
-        # )
-
         wizard.select_other_modules()
         self.assertFalse(
             self.website_module.id in wizard.module_ids.ids,
             "Select Other module should not select 'product' module",
         )
-
         wizard.unselect_modules()
         self.assertEqual(
             wizard.module_ids.ids, [], "Unselect module should clear the selection"

upgrade_analysis/views/view_upgrade_analysis.xml

@@ -27,7 +27,7 @@
                     />
                 </header>
                 <sheet>
-                    <group col="4" colspan="4">
+                    <group>
                         <field
                             name="config_id"
                             attrs="{'readonly': [('state', '=', 'done')]}"
@@ -51,6 +51,7 @@
                             nolabel="1"
                             widget="ace"
                             options="{'mode': 'txt'}"
+                            colspan="2"
                         />
                     </group>
 

upgrade_analysis/views/view_upgrade_record.xml

@@ -44,7 +44,7 @@
         <field name="arch" type="xml">
             <form>
                 <sheet>
-                    <group col="4" colspan="4">
+                    <group>
                         <field name="name" />
                         <field name="module" />
                         <field name="model" />
@@ -53,7 +53,7 @@
                         <field name="mode" />
                     </group>
                     <group string="Attributes">
-                        <field name="attribute_ids" nolabel="1" colspan="4">
+                        <field name="attribute_ids" nolabel="1" colspan="2">
                             <tree>
                                 <field name="name" />
                                 <field name="value" />

upgrade_analysis/wizards/upgrade_install_wizard.py

@@ -24,6 +24,7 @@ class UpgradeInstallWizard(models.TransientModel):
     module_ids = fields.Many2many(
         comodel_name="ir.module.module",
         domain=lambda x: x._module_ids_domain(),
+        string="Modules",
     )
 
     module_qty = fields.Integer(

upgrade_analysis/wizards/view_upgrade_generate_record_wizard.xml

@@ -8,12 +8,13 @@
                 <header>
                   <field name="state" widget="statusbar" />
                 </header>
-                <group states="draft" colspan="4">
+                <group states="draft">
                     <p
+                        colspan="2"
                     >This will reinitialize all the modules installed on this database. Do not continue if you use this database in production.</p>
                 </group>
-                <group states="done" colspan="4">
-                    <p>Modules initialized and record created</p>
+                <group states="done">
+                    <p colspan="2">Modules initialized and record created</p>
                 </group>
                 <footer>
                     <button

upgrade_analysis/wizards/view_upgrade_install_wizard.xml

@@ -12,15 +12,17 @@
                     <p
                         class="alert alert-warning"
                         role="alert"
+                        colspan="2"
                     >This will install the selected modules on the database. Do not continue if you use this database in production.</p>
                 </group>
                 <group states="done">
                     <p
                         class="alert alert-info"
                         role="alert"
+                        colspan="2"
                     >The modules have been installed successfuly</p>
                 </group>
-                <group col="4" states="draft">
+                <header states="draft">
                     <button
                         name="select_installable_modules"
                         type="object"
@@ -42,7 +44,13 @@
                         type="object"
                         string="All Other Modules"
                     />
-                </group>
+                </header>
+                <button
+                    name="unselect_modules"
+                    type="object"
+                    string="Clear the list"
+                    states="draft"
+                />
                 <group states="draft">
                     <field name="module_qty" />
                     <field
@@ -50,11 +58,6 @@
                         widget="many2many_tags"
                         options="{'no_create': True}"
                     />
-                    <button
-                        name="unselect_modules"
-                        type="object"
-                        string="Clear the list"
-                    />
                 </group>
                 <footer>
                     <button