From 681626fab864a1955a90bb931c7368625ab65092 Mon Sep 17 00:00:00 2001 From: Jairo Llopis Date: Wed, 28 Oct 2015 16:05:16 +0100 Subject: [PATCH 1/3] Fix argument name that did not let users to sign up in runbot. See https://github.com/OCA/server-tools/pull/277#discussion_r42502847 --- auth_from_http_remote_user/res_users.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/auth_from_http_remote_user/res_users.py b/auth_from_http_remote_user/res_users.py index 638179405..a12bc2eb9 100644 --- a/auth_from_http_remote_user/res_users.py +++ b/auth_from_http_remote_user/res_users.py @@ -34,10 +34,10 @@ class res_users(orm.Model): readonly=True), } - def copy(self, cr, uid, rid, defaults=None, context=None): - defaults = defaults or {} - defaults['sso_key'] = False - return super(res_users, self).copy(cr, uid, rid, defaults, context) + def copy(self, cr, uid, rid, default=None, context=None): + default = default or {} + default['sso_key'] = False + return super(res_users, self).copy(cr, uid, rid, default, context) def check_credentials(self, cr, uid, password): try: From 105e4efece7f12f1c6c7fb0dd9075553519f8f99 Mon Sep 17 00:00:00 2001 From: Jairo Llopis Date: Wed, 28 Oct 2015 16:46:58 +0100 Subject: [PATCH 2/3] Another typo. --- auth_from_http_remote_user/res_users.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/auth_from_http_remote_user/res_users.py b/auth_from_http_remote_user/res_users.py index a12bc2eb9..f843c94db 100644 --- a/auth_from_http_remote_user/res_users.py +++ b/auth_from_http_remote_user/res_users.py @@ -34,10 +34,10 @@ class res_users(orm.Model): readonly=True), } - def copy(self, cr, uid, rid, default=None, context=None): + def copy(self, cr, uid, id, default=None, context=None): default = default or {} default['sso_key'] = False - return super(res_users, self).copy(cr, uid, rid, default, context) + return super(res_users, self).copy(cr, uid, id, default, context) def check_credentials(self, cr, uid, password): try: From 214efbf80256f180bdf23177aada4d9c9b0fbac6 Mon Sep 17 00:00:00 2001 From: Jairo Llopis Date: Thu, 29 Oct 2015 16:08:48 +0100 Subject: [PATCH 3/3] Do not recreate variable in case of dict(). --- auth_from_http_remote_user/res_users.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/auth_from_http_remote_user/res_users.py b/auth_from_http_remote_user/res_users.py index f843c94db..4989e3fac 100644 --- a/auth_from_http_remote_user/res_users.py +++ b/auth_from_http_remote_user/res_users.py @@ -35,7 +35,7 @@ class res_users(orm.Model): } def copy(self, cr, uid, id, default=None, context=None): - default = default or {} + default = default = {} if default is None else default default['sso_key'] = False return super(res_users, self).copy(cr, uid, id, default, context)