From 82e00422083ac1294c4860033764be7388f4bb9c Mon Sep 17 00:00:00 2001
From: Thierry Ducrest <thierry.ducrest@camptocamp.com>
Date: Wed, 24 Mar 2021 13:28:41 +0100
Subject: [PATCH] [13.0][IMP] base_exception add blocking exceptions

By default exceptions can be ignored by the click of a button.
Users begin human they will just click that button what ever
the internal rules.

So this PR adds the option to set specific exceptions as blocking.

When exceptions are detected if one of them is blocking, the user
will not be able to ignore them.
---
 base_exception/models/base_exception.py      | 23 ++++++++++++++++++--
 base_exception/views/base_exception_view.xml |  1 +
 2 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/base_exception/models/base_exception.py b/base_exception/models/base_exception.py
index 0eb552b48..2bbb5c32b 100644
--- a/base_exception/models/base_exception.py
+++ b/base_exception/models/base_exception.py
@@ -42,6 +42,9 @@ class ExceptionRule(models.Model):
         help="Python code executed to check if the exception apply or "
         "not. Use failed = True to block the exception",
     )
+    is_blocking = fields.Boolean(
+        string="Is blocking", help="When checked the exception can not be ignored",
+    )
 
     @api.constrains("exception_type", "domain", "code")
     def check_exception_type_consistency(self):
@@ -201,6 +204,13 @@ class BaseExceptionModel(models.AbstractModel):
     ignore_exception = fields.Boolean("Ignore Exceptions", copy=False)
 
     def action_ignore_exceptions(self):
+        if any(self.exception_ids.mapped("is_blocking")):
+            raise UserError(
+                _(
+                    "The exceptions can not be ignored, because "
+                    "some of them are blocking."
+                )
+            )
         self.write({"ignore_exception": True})
         return True
 
@@ -218,8 +228,17 @@ class BaseExceptionModel(models.AbstractModel):
             if rec.exception_ids and not rec.ignore_exception:
                 rec.exceptions_summary = "<ul>%s</ul>" % "".join(
                     [
-                        "<li>%s: <i>%s</i></li>"
-                        % tuple(map(html.escape, (e.name, e.description or "")))
+                        "<li>%s: <i>%s</i> <b>%s<b></li>"
+                        % tuple(
+                            map(
+                                html.escape,
+                                (
+                                    e.name,
+                                    e.description or "",
+                                    _("(Blocking exception)") if e.is_blocking else "",
+                                ),
+                            )
+                        )
                         for e in rec.exception_ids
                     ]
                 )
diff --git a/base_exception/views/base_exception_view.xml b/base_exception/views/base_exception_view.xml
index cf894605b..876b9db01 100644
--- a/base_exception/views/base_exception_view.xml
+++ b/base_exception/views/base_exception_view.xml
@@ -49,6 +49,7 @@
                                 widget="domain"
                                 options="{'model': 'model'}"
                             />
+                            <field name="is_blocking" />
                         </group>
                     </group>
                     <notebook>