[IMP] onchange_helper: black, isort

pull/2235/head
laurent.corron 2019-10-18 14:56:56 +02:00 committed by Koen Loodts
parent dd20ed5447
commit 70da5fc226
3 changed files with 31 additions and 38 deletions

View File

@ -2,14 +2,13 @@
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
{ {
'name': 'Onchange Helper', "name": "Onchange Helper",
'version': '12.0.1.0.0', "version": "12.0.1.0.0",
'summary': 'Technical module that ease execution' "summary": "Technical module that ease execution" " of onchange in Python code",
' of onchange in Python code', "author": "Akretion,Camptocamp,Odoo Community Association (OCA)",
'author': 'Akretion,Camptocamp,Odoo Community Association (OCA)', "website": "https://github.com/OCA/server-tools",
'website': 'https://github.com/OCA/server-tools', "license": "AGPL-3",
'license': 'AGPL-3', "category": "Generic Modules",
'category': 'Generic Modules', "depends": ["base"],
'depends': ['base'], "installable": True,
'installable': True,
} }

View File

@ -6,16 +6,16 @@ from odoo import api, models
class Base(models.AbstractModel): class Base(models.AbstractModel):
_inherit = 'base' _inherit = "base"
@api.model @api.model
def _get_new_values(self, record, on_change_result): def _get_new_values(self, record, on_change_result):
vals = on_change_result.get('value', {}) vals = on_change_result.get("value", {})
new_values = {} new_values = {}
for fieldname, value in vals.items(): for fieldname, value in vals.items():
if fieldname not in record: if fieldname not in record:
column = self._fields[fieldname] column = self._fields[fieldname]
if value and column.type == 'many2one': if value and column.type == "many2one":
value = value[0] # many2one are tuple (id, name) value = value[0] # many2one are tuple (id, name)
new_values[fieldname] = value new_values[fieldname] = value
return new_values return new_values
@ -33,9 +33,7 @@ class Base(models.AbstractModel):
# _onchange_spec() will return onchange fields from the default view # _onchange_spec() will return onchange fields from the default view
# we need all fields in the dict even the empty ones # we need all fields in the dict even the empty ones
# otherwise 'onchange()' will not apply changes to them # otherwise 'onchange()' will not apply changes to them
onchange_specs = { onchange_specs = {field_name: "1" for field_name, field in self._fields.items()}
field_name: '1' for field_name, field in self._fields.items()
}
all_values = values.copy() all_values = values.copy()
# If self is a record (play onchange on existing record) # If self is a record (play onchange on existing record)
# we take the value of the field # we take the value of the field

View File

@ -6,31 +6,27 @@ from odoo.tests.common import TransactionCase
class TestOnchangeHelper(TransactionCase): class TestOnchangeHelper(TransactionCase):
def test01_partner_parent(self): def test01_partner_parent(self):
main_partner = self.env.ref('base.main_partner') main_partner = self.env.ref("base.main_partner")
input_vals = dict(parent_id=main_partner.id, type='contact') input_vals = dict(parent_id=main_partner.id, type="contact")
updated_vals = self.env['res.partner'].play_onchanges( updated_vals = self.env["res.partner"].play_onchanges(input_vals, ["parent_id"])
input_vals, ['parent_id'] self.assertIn("country_id", updated_vals)
) self.assertIn("state_id", updated_vals)
self.assertIn('country_id', updated_vals) self.assertIn("street", updated_vals)
self.assertIn('state_id', updated_vals) self.assertIn("zip", updated_vals)
self.assertIn('street', updated_vals)
self.assertIn('zip', updated_vals)
self.assertEqual( self.assertEqual(updated_vals["country_id"], main_partner.country_id.id)
updated_vals['country_id'], main_partner.country_id.id self.assertEqual(updated_vals["state_id"], main_partner.state_id.id)
) self.assertEqual(updated_vals["street"], main_partner.street)
self.assertEqual(updated_vals['state_id'], main_partner.state_id.id) self.assertEqual(updated_vals["zip"], main_partner.zip)
self.assertEqual(updated_vals['street'], main_partner.street)
self.assertEqual(updated_vals['zip'], main_partner.zip)
def test02_partner_country(self): def test02_partner_country(self):
partner_demo = self.env.ref('base.partner_demo') partner_demo = self.env.ref("base.partner_demo")
input_vals = {'country_id': self.env.ref('base.us').id} input_vals = {"country_id": self.env.ref("base.us").id}
updated_vals = partner_demo.play_onchanges(input_vals, ['country_id']) updated_vals = partner_demo.play_onchanges(input_vals, ["country_id"])
self.assertIn('country_id', updated_vals) self.assertIn("country_id", updated_vals)
def test_playing_onchange_on_model(self): def test_playing_onchange_on_model(self):
result = self.env['res.partner'].play_onchanges( result = self.env["res.partner"].play_onchanges(
{'company_type': 'company'}, ['company_type'] {"company_type": "company"}, ["company_type"]
) )
self.assertEqual(result['is_company'], True) self.assertEqual(result["is_company"], True)