Techsystech
/
server-tools
mirror of https://github.com/OCA/server-tools.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[IMP] base_exception: Improves performances 

Don't call the ORM to filter current recordset. Replace call to the orm by a call to the filtered_domain method.
pull/2670/head
Laurent Mignon (ACSONE) 2023-07-04 15:41:47 +02:00
parent 254c5684e3
commit 31c074cdc3
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
base_exception/models/base_exception_method.py
View File

@ -119,14 +119,14 @@ class BaseExceptionMethod(models.AbstractModel):
return self._detect_exceptions_by_method(rule_info) return self._detect_exceptions_by_method(rule_info)
def _get_base_domain(self): def _get_base_domain(self):
return [("ignore_exception", "=", False), ("id", "in", self.ids)] return [("ignore_exception", "=", False)]
def _detect_exceptions_by_py_code(self, rule_info): def _detect_exceptions_by_py_code(self, rule_info):
""" """
Find exceptions found on self. Find exceptions found on self.
""" """
domain = self._get_base_domain() domain = self._get_base_domain()
records = self.search(domain) records = self.filtered_domain(domain)
records_with_exception = self.env[self._name] records_with_exception = self.env[self._name]
for record in records: for record in records:
if self._rule_eval(rule_info, record): if self._rule_eval(rule_info, record):
@ -140,12 +140,12 @@ class BaseExceptionMethod(models.AbstractModel):
base_domain = self._get_base_domain() base_domain = self._get_base_domain()
rule_domain = rule_info.domain rule_domain = rule_info.domain
domain = expression.AND([base_domain, rule_domain]) domain = expression.AND([base_domain, rule_domain])
return self.search(domain) return self.filtered_domain(domain)
def _detect_exceptions_by_method(self, rule_info): def _detect_exceptions_by_method(self, rule_info):
""" """
Find exceptions found on self. Find exceptions found on self.
""" """
base_domain = self._get_base_domain() base_domain = self._get_base_domain()
records = self.search(base_domain) records = self.filtered_domain(base_domain)
return getattr(records, rule_info.method)() return getattr(records, rule_info.method)()