Commit Graph

56 Commits (8f97edeb0ab6bc4a8442aac812a46a865e18bf0f)

Author SHA1 Message Date
Enric Tobella c9b60014ee [FIX] account_reconcile_oca: Apply matching of partners on reconciliation models 2025-04-11 10:38:02 +02:00
Enric Tobella 64b048cd9f [IMP] account_reconcile_oca: Allow an option to avoid a function 2025-04-03 08:08:48 +02:00
Víctor Martínez f9341aeda7 [FIX] account_reconcile_oca: Avoiding the singleton error related to _get_reconcile_line()
Example use case:
 File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 541, in _compute_reconcile_data_info
    record.reconcile_data_info = record._default_reconcile_data(
  File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 698, in _default_reconcile_data
    reconcile_auxiliary_id, lines = self._get_reconcile_line(
  File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 1164, in _get_reconcile_line
    new_vals = super()._get_reconcile_line(
  File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_reconcile_abstract.py", line 49, in _get_reconcile_line
    original_amount = amount = net_amount = line.debit - line.credit
  File "/opt/odoo/custom/src/odoo/odoo/fields.py", line 1154, in __get__
    record.ensure_one()
  File "/opt/odoo/custom/src/odoo/odoo/models.py", line 5204, in ensure_one
    raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: account.move.line(208, 211, 212)

TT55221
2025-02-26 17:10:28 +01:00
Víctor Martínez 2c5e7accb6 [FIX] account_reconcile_oca: Set the appropriate value for partner_id to avoid warning log
WARNING prod py.warnings: /opt/odoo/auto/addons/account/models/account_move.py:4651: UserWarning: unsupported operand type(s) for "==": 'res.partner()' == '403'
2025-02-20 09:54:58 +01:00
Víctor Martínez dcd9a75d5d [FIX] account_reconcile_oca: Replace name_get() to delete the warning log
WARNING prod py.warnings: /opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py:616: DeprecationWarning: Since 17.0, deprecated method, read display_name instead
2025-02-20 09:39:53 +01:00
Enric Tobella 42b756b22c [IMP] account_reconcile_oca: Allow to select all lines at once 2025-02-12 11:59:41 +01:00
OCA-git-bot 3606a9a9e4 Merge PR #788 into 17.0
Signed-off-by pedrobaeza
2025-02-11 07:27:53 +00:00
Florian da Costa 56f90720ab [FIX] Replace removed compute method by _convert 2025-02-10 09:48:55 +01:00
Florian da Costa 4ea691ce3e [FIX] partner update from reconciliation widget
We cant to avoid to change amounts on accounting entries during the reconciliation process. One of the goal is to avoid a following case :
The statement line is created in a foreign currency journal, later, the rate is updated in Odoo.
During reconciliation process, the partner is set on liquidity line, the accounting entries are synchronized and the balance changes.
2025-02-10 09:34:09 +01:00
Florian da Costa 82eb24b736 [FIX] Synchronise partner from statement line to accounting entries
We need to look at the reconcile_data to find the partner as the manual_partner_id can contain the information of an auxiliary line
2025-02-10 09:26:23 +01:00
Víctor Martínez 8c34bd0d89 [FIX] account_reconcile_oca: Synchronize manual_partner_id with partner_id without onchange or subsequent changes with the _synchronize_to_moves() method.
We do not define partner_id with the value of manual_partner_id to prevent _synchronize_to_moves()
from making changes to the account.move.line leaving unintended values and/or data.

Re-define the value of reconcile_data_info if the _synchronize_to_moves() method has changed
anything on the lines.

Related to https://github.com/OCA/account-reconcile/issues/779

TT52634
2025-02-10 09:26:16 +01:00
Sergio Bustamante 705aeafa7f [FIX] account_reconcile_oca: Fix currency and amount when using reconciliation models 2025-02-10 09:23:49 +01:00
Florian da Costa 89e3e78729 [FIX] Wrong amount currency compute in case of change in liquidity line 2025-02-10 09:23:49 +01:00
Florian da Costa 811ff1e0b4 [FIX] fix _check_line_changed partner check 2025-02-10 09:23:49 +01:00
Enric Tobella 3dc4202e50 [FIX] account_reconcile_oca: Update currency_amount 2025-02-10 09:23:49 +01:00
Florian da Costa 3e7b7ad3b9 [FIX] account_reconcile_oca : exchange rate gain/loss currency and amount
If currency amount is not 0, the suspense line will have wrong amount
2025-02-10 09:23:49 +01:00
Florian da Costa 32ae16dc0a [FIX] account_reconcile_oca : max_amount rounding error leading to unwanted currency conversion 2025-02-10 09:23:49 +01:00
Florian da Costa 7792a6f4be [FIX] account_reconcile_oca : foreign currency reconcile with late currency rate
It is possible that the statement line in foreign currency is created before the rate of the day is updated in Odoo. In this case we need to take the real rate of the statement line to comput the exchange rate
2025-02-10 09:23:49 +01:00
Florian da Costa 6348cf50fa [FIX] account_reconcile_oca : Fix multi currency management
Fix the case of payment with a foreign currency set on bank statement line

improve tests around multi-currency
2025-02-10 09:23:49 +01:00
Enric Tobella 01f43d6ff6 [IMP] account_reconcile_oca: Improve multicurrency management.
We will use currency of the line in order to get the suspense and max line value
2025-02-10 09:23:31 +01:00
Tom 813e950847 [FIX] #11339 account_reconcile_oca: KeyError on data 2025-02-05 09:18:39 +01:00
Víctor Martínez 64b1d4b710 [IMP] account_reconcile_oca: Add auto-reconcile compatibility (Example: Rule to match invoices/bills)
TT52146

[FIX] account_reconcile_oca: Fix test related to match_text_location fields

Related to 8948b31407

TT52146
2024-12-17 14:52:15 +01:00
OCA-git-bot 3b7014780b Merge PR #764 into 17.0
Signed-off-by pedrobaeza
2024-12-17 10:22:14 +00:00
bobrador 7bb5bda6d7 [FIX] account_reconcile_oca: Fixed analytic distribution update
This fixes a bug that occurred when both account_reconcile_oca and account_reconcile_model_oca modules were installed. The issue arose when assigning an analytic account and making no further changes, causing the analytic account to not be set correctly. As a result, the reconciliation process failed to create the analytic entries properly. This line: ensures that if the analytic distribution has changed, it will be correctly updated.
2024-12-16 11:50:49 +01:00
bobrador dcd69cc3ed [IMP] account_reconcile_oca: Add validation for applicability of analytic plans
adds validation for the applicability of analytic plans, ensuring that mandatory plans or accounts requiring analytic imputations are properly validated.

    The validate_analytic context is used in the analytic mixin to validate the applicability of analytic plans when generating analytic lines.
2024-12-16 11:40:03 +01:00
Enric Tobella 69cf2d206a [IMP] account_reconcile_oca: Use receivable/payable account on statements with partner as suspense account 2024-12-09 08:29:11 +01:00
Víctor Martínez 7bcf45377a [IMP] account_reconcile_oca: Hook methods
Useful for extensions like this one https://github.com/OCA/account-reconcile/pull/758

TT51885
2024-11-27 17:23:07 +01:00
Florian da Costa b6fefe3ea5 [FIX] account_reconcile_oca : keep partner line case of manual button reconcile 2024-11-18 11:40:34 +01:00
Florian da Costa 689eb413a7 [16][FIX] account_reconcile_oca : keep aml label when empty on manual write-off reconcile model 2024-11-18 09:28:22 +01:00
Víctor Martínez 99e8c46ecf [IMP] account_reconcile_oca: Remove warning: Two fields have the same label: Manual In Currency.
WARNING devel odoo.addons.base.models.ir_model: Two fields
(manual_in_currency_id, manual_in_currency) of account.bank.statement.line()
have the same label: Manual In Currency.
[Modules: account_reconcile_oca and account_reconcile_oca]
2024-10-09 10:12:36 +02:00
Víctor Martínez 6b650cc776 [IMP] account_reconcile_oca: Remove warning (deprecated method, read display_name instead)
WARNING devel py.warnings: /opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py:938:
DeprecationWarning: Since 17.0, deprecated method, read display_name instead
2024-10-09 10:08:21 +02:00
Enric Tobella 65f62d2c06 [FIX] account_reconcile_oca: Fix wrong display on reconciled moves
If your reconcile an invoice and in the old option, the reconcile widget shows something weird with three lines but we should have only two. The data was right with 2 lines only.
2024-10-01 13:04:04 +02:00
Enric Tobella 1dd39fc695 [IMP] account_reconcile_oca: Compute the exchange rate properly 2024-10-01 13:04:04 +02:00
Enric Tobella 5c9e90c8e6 [IMP] account_reconcile_oca: Fix multi currency computation 2024-10-01 13:04:01 +02:00
PNurm 74d084c63a [FIX] account_reconcile_oca: Pass partner parameter correctly to _get_write_off_move_lines_dict 2024-09-08 15:14:59 +02:00
JordiMForgeFlow 647db34317 [IMP] account_reconcile_oca: reverse reconcile entry when resetting reconciliation in keep mode 2024-05-30 13:39:14 +02:00
Pedro M. Baeza 90ca34afc2 [FIX] *: pre-commit fixes
Due to latest copier template with all the checks.
2024-05-01 19:31:30 +02:00
Enric Tobella f85338ffb0 [IMP] account_reconcile_oca: Allow aggregation for more parameters 2024-04-22 14:38:09 +02:00
Enric Tobella b64ffc6eda [IMP] account_reconcile_oca: Allow to define the statement directly 2024-04-22 10:37:56 +02:00
Enric Tobella c408c0f059 [FIX] account_reconcile_oca: Use counterparts properly 2024-04-21 02:16:01 +02:00
Enric Tobella 4a5e33919d [FIX] account_reconcile_oca: Fix foreign currency 2024-04-21 02:11:53 +02:00
Enric Tobella 98e0d559ba [MIG] account_reconcile_oca: Finish migration 2024-02-08 23:06:58 +01:00
Henrik Norlin a5f04c08f7 [MIG] account_reconcile_oca: Migration to 17.0 2024-02-08 23:06:58 +01:00
Henrik Norlin 214337719b [IMP] account_reconcile_oca: black, isort, prettier 2024-02-08 23:06:58 +01:00
Enric Tobella f3956c9e52 [UPD] account_reconcile_oca: Add Dixmit as author 2024-02-07 22:10:36 +01:00
Andrea Stirpe c514a854d9 [16.0][IMP] account_reconcile_oca: display partner_name 2024-02-07 22:10:07 +01:00
Enric Tobella 4cbe8d96b6 [FIX] account_reconcile_oca: Show manual amount in the right currency 2024-02-07 22:09:55 +01:00
Enric Tobella 3d6a561180 [IMP] account_reconcile_oca: only store info on unreconciled items 2024-02-07 22:09:51 +01:00
Enric Tobella 7fe47375c6 [FIX] account_reconcile_oca: Models where failing on default with a different currency 2024-02-07 22:09:45 +01:00
Enric Tobella e15b76822f [FIX] account_reconcile_oca: Make it work with foreign currency 2024-02-07 22:09:45 +01:00