From 0e4f79c9083255782c4dd3a01d8ec27780d9a212 Mon Sep 17 00:00:00 2001 From: Florian da Costa Date: Wed, 22 Jan 2025 11:06:44 +0100 Subject: [PATCH] [FIX] fix _check_line_changed partner check --- account_reconcile_oca/models/account_bank_statement_line.py | 6 +++++- account_reconcile_oca/tests/test_bank_account_reconcile.py | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/account_reconcile_oca/models/account_bank_statement_line.py b/account_reconcile_oca/models/account_bank_statement_line.py index 565e5f6f..8ebd1f07 100644 --- a/account_reconcile_oca/models/account_bank_statement_line.py +++ b/account_reconcile_oca/models/account_bank_statement_line.py @@ -322,7 +322,11 @@ class AccountBankStatementLine(models.Model): ) or self.manual_account_id.id != line["account_id"][0] or self.manual_name != line["name"] - or (self.manual_partner_id and self.manual_partner_id.display_name or False) + or ( + self.manual_partner_id + and [self.manual_partner_id.id, self.manual_partner_id.display_name] + or [False, False] + ) != line.get("partner_id") or self.analytic_distribution != line.get("analytic_distribution", False) ) diff --git a/account_reconcile_oca/tests/test_bank_account_reconcile.py b/account_reconcile_oca/tests/test_bank_account_reconcile.py index fe7c9b95..d8ab3fad 100644 --- a/account_reconcile_oca/tests/test_bank_account_reconcile.py +++ b/account_reconcile_oca/tests/test_bank_account_reconcile.py @@ -1141,7 +1141,7 @@ class TestReconciliationWidget(TestAccountReconciliationCommon): 259200, ) f.add_account_move_line_id = inv1.line_ids.filtered( - lambda l: l.account_id.account_type == "asset_receivable" + lambda line: line.account_id.account_type == "asset_receivable" ) self.assertTrue(f.can_reconcile) self.assertEqual(len(bank_stmt_line.reconcile_data_info["data"]), 3) @@ -1317,7 +1317,7 @@ class TestReconciliationWidget(TestAccountReconciliationCommon): # simulate click on statement line, check amount does not recompute self.assertEqual(f.manual_amount, 83.33) f.add_account_move_line_id = inv1.line_ids.filtered( - lambda l: l.account_id.account_type == "asset_receivable" + lambda line: line.account_id.account_type == "asset_receivable" ) self.assertEqual(3, len(f.reconcile_data_info["data"])) self.assertTrue(f.can_reconcile)