Techsystech
/
OCA_Reporting_engine_17.0
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[IMP] - use display for element visibility 

the visibility attribute with the hidden option hides the element but
don't free the space.

A common use case is to have a specific header for the first page and
another for the other pages. With visibility: hidden the second header
cannot take the first one place and will keep a huge margin.
One solution is to use the display:none instead.
pull/507/head
sbejaoui 2021-04-30 15:23:17 +02:00
parent e1a0b599ed
commit 7b0f371f47
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
report_qweb_element_page_visibility/views/layouts.xml
View File

@ -32,16 +32,16 @@
} }
var operations = { var operations = {
'not-first-page': function (elt) { 'not-first-page': function (elt) {
elt.style.visibility = (vars.sitepage === vars.frompage) ? "hidden" : "visible"; elt.style.display = (vars.sitepage === vars.frompage) ? "none" : "inherit";
}, },
'not-last-page': function (elt) { 'not-last-page': function (elt) {
elt.style.visibility = (vars.sitepage === vars.sitepages) ? "hidden" : "visible"; elt.style.display = (vars.sitepage === vars.sitepages) ? "none" : "inherit";
}, },
'first-page': function (elt) { 'first-page': function (elt) {
elt.style.visibility = (vars.sitepage === vars.frompage) ? "visible" : "hidden"; elt.style.display = (vars.sitepage === vars.frompage) ? "inherit" : "none";
}, },
'last-page': function (elt) { 'last-page': function (elt) {
elt.style.visibility = (vars.sitepage === vars.sitepages) ? "visible" : "hidden"; elt.style.display = (vars.sitepage === vars.sitepages) ? "inherit" : "none";
}, },
}; };
for (var klass in operations) { for (var klass in operations) {