Techsystech
/
OCA_Reporting_engine_17.0
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[FIX] base_comment_template: Filter domain correctly 

1. Safe eval domain before checking if it is defined. This makes [] be "False" on the first check, and provides the proper use case for when the domain is empty
2. Use filtered_domain in record instead of a search in self. When on a compute, we are on a NewId context, so the search would always fail

TT29309
pull/646/head
João Marques 2021-05-25 09:04:26 +01:00 committed by Víctor Martínez
parent 9a366d77d1
commit 724fb2d3d6
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
base_comment_template/models/comment_template.py
View File

@ -39,7 +39,6 @@ class CommentTemplate(models.AbstractModel):
] ]
) )
for template in templates: for template in templates:
if not template.domain or self in self.search( domain = safe_eval(template.domain)
safe_eval(template.domain) if not domain or record.filtered_domain(domain):
):
record.comment_template_ids = [(4, template.id)] record.comment_template_ids = [(4, template.id)]