[FIX] base_comment_template: Filter domain correctly
1. Safe eval domain before checking if it is defined. This makes [] be "False" on the first check, and provides the proper use case for when the domain is empty 2. Use filtered_domain in record instead of a search in self. When on a compute, we are on a NewId context, so the search would always fail TT29309pull/646/head
parent
9a366d77d1
commit
724fb2d3d6
|
@ -39,7 +39,6 @@ class CommentTemplate(models.AbstractModel):
|
|||
]
|
||||
)
|
||||
for template in templates:
|
||||
if not template.domain or self in self.search(
|
||||
safe_eval(template.domain)
|
||||
):
|
||||
domain = safe_eval(template.domain)
|
||||
if not domain or record.filtered_domain(domain):
|
||||
record.comment_template_ids = [(4, template.id)]
|
||||
|
|
Loading…
Reference in New Issue