[FIX] base_comment_template: Filter domain correctly

1. Safe eval domain before checking if it is defined. This makes [] be "False" on the first check, and provides the proper use case for when the domain is empty
2. Use filtered_domain in record instead of a search in self. When on a compute, we are on a NewId context, so the search would always fail

TT29309
pull/512/head
João Marques 2021-05-25 09:04:26 +01:00 committed by Víctor Martínez
parent 4c6d57d446
commit 47ed1ea795
1 changed files with 2 additions and 3 deletions

View File

@ -39,7 +39,6 @@ class CommentTemplate(models.AbstractModel):
]
)
for template in templates:
if not template.domain or self in self.search(
safe_eval(template.domain)
):
domain = safe_eval(template.domain)
if not domain or record.filtered_domain(domain):
record.comment_template_ids = [(4, template.id)]