[IMP] Allow to override/extend the way we get the fallback template

report_py3o/models/py3o_report.py

@@ -83,30 +83,13 @@ class Py3oReport(models.TransientModel):
     )
 
     @api.multi
-    def get_template(self):
+    def _get_template_from_path(self, tmpl_name):
-        """private helper to fetch the template data either from the database
+        """"Return the template from the path to root of the module if specied
-        or from the default template file provided by the implementer.
+        or an absolute path on your server
-
-        ATM this method takes a report definition recordset
-        to try and fetch the report template from database. If not found it
-        will fallback to the template file referenced in the report definition.
-
-        @returns: string or buffer containing the template data
-
-        @raises: TemplateNotFound which is a subclass of
-        odoo.exceptions.DeferredException
         """
-        self.ensure_one()
+        if not tmpl_name:
-        tmpl_data = None
+            return None
         report_xml = self.ir_actions_report_xml_id
-        if report_xml.py3o_template_id and report_xml.py3o_template_id.id:
-            # if a user gave a report template
-            tmpl_data = b64decode(
-                report_xml.py3o_template_id.py3o_template_data
-            )
-
-        elif report_xml.py3o_template_fallback:
-            tmpl_name = report_xml.py3o_template_fallback
         flbk_filename = None
         if report_xml.module:
             # if the default is defined
@@ -120,7 +103,43 @@ class Py3oReport(models.TransientModel):
         if flbk_filename and os.path.exists(flbk_filename):
             # and it exists on the fileystem
             with open(flbk_filename, 'r') as tmpl:
-                    tmpl_data = tmpl.read()
+                return tmpl.read()
+        return None
+
+    @api.multi
+    def _get_template_fallback(self, model_instance):
+        """
+        Return the template referenced in the report definition
+        :return:
+        """
+        self.ensure_one()
+        report_xml = self.ir_actions_report_xml_id
+        return self._get_template_from_path(report_xml.py3o_template_fallback)
+
+    @api.multi
+    def get_template(self, model_instance):
+        """private helper to fetch the template data either from the database
+        or from the default template file provided by the implementer.
+
+        ATM this method takes a report definition recordset
+        to try and fetch the report template from database. If not found it
+        will fallback to the template file referenced in the report definition.
+
+        @returns: string or buffer containing the template data
+
+        @raises: TemplateNotFound which is a subclass of
+        odoo.exceptions.DeferredException
+        """
+        self.ensure_one()
+        report_xml = self.ir_actions_report_xml_id
+        if report_xml.py3o_template_id and report_xml.py3o_template_id.id:
+            # if a user gave a report template
+            tmpl_data = b64decode(
+                report_xml.py3o_template_id.py3o_template_data
+            )
+
+        else:
+            tmpl_data = self._get_template_fallback(model_instance)
 
         if tmpl_data is None:
             # if for any reason the template is not found
@@ -197,7 +216,7 @@ class Py3oReport(models.TransientModel):
         filetype = report_xml.py3o_filetype
         result_fd, result_path = tempfile.mkstemp(
             suffix='.' + filetype, prefix='p3o.report.tmp.')
-        tmpl_data = self.get_template()
+        tmpl_data = self.get_template(model_instance)
 
         in_stream = StringIO(tmpl_data)
         with closing(os.fdopen(result_fd, 'w+')) as out_stream: